Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2309893002: Revert "Percent height content should respect the fixed height of its containing cell" (Closed)

Created:
4 years, 3 months ago by rhogan
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -243 lines) Patch
M third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/031-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/031-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt View 2 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 7 chunks +11 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
rhogan
Hi eae - this is different from the reversion trunk (https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54) as there were conflicts. ...
4 years, 3 months ago (2016-09-05 17:48:19 UTC) #3
rhogan
4 years, 3 months ago (2016-09-05 18:26:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ff2ee19735711589f6842da1b5f1f1a37072082c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698