Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2439273002: Clean up ownership in WebUI creation. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ownership in WebUI creation. BUG=555865 Committed: https://crrev.com/e865b1df520e0dfac85cf77958d80e220676d829 Cr-Commit-Position: refs/heads/master@{#427121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M chrome/browser/ui/webui/uber/uber_ui.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M content/public/browser/web_contents.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Avi (use Gerrit)
4 years, 2 months ago (2016-10-22 05:03:53 UTC) #4
jam
lgtm
4 years, 1 month ago (2016-10-24 16:59:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439273002/1
4 years, 1 month ago (2016-10-24 17:02:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 19:43:24 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 19:55:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e865b1df520e0dfac85cf77958d80e220676d829
Cr-Commit-Position: refs/heads/master@{#427121}

Powered by Google App Engine
This is Rietveld 408576698