Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: chrome/browser/ui/webui/uber/uber_ui.h

Issue 2439273002: Clean up ownership in WebUI creation. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/uber/uber_ui.h
diff --git a/chrome/browser/ui/webui/uber/uber_ui.h b/chrome/browser/ui/webui/uber/uber_ui.h
index f3c2107a02d0e25f3ea401396f309349bd56af60..05e799a6945738496c67b10e545a7bd4989fe9bb 100644
--- a/chrome/browser/ui/webui/uber/uber_ui.h
+++ b/chrome/browser/ui/webui/uber/uber_ui.h
@@ -57,17 +57,14 @@ class UberUI : public content::WebUIController {
void RenderViewCreated(content::RenderViewHost* render_view_host) override;
private:
- // A map from URL origin to WebUI instance.
- typedef std::map<std::string, content::WebUI*> SubpageMap;
-
// Creates and stores a WebUI for the given URL.
void RegisterSubpage(const std::string& page_url,
const std::string& page_host);
SubframeLogger subframe_logger_;
- // The WebUI*s in this map are owned.
- SubpageMap sub_uis_;
+ // Map from URL origin to WebUI instance.
+ std::map<std::string, std::unique_ptr<content::WebUI>> sub_uis_;
DISALLOW_COPY_AND_ASSIGN(UberUI);
};
« no previous file with comments | « no previous file | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698