Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2439273002: Clean up ownership in WebUI creation. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/uber/uber_ui.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 000a9316e71c54b5e5392441ff6a4041ccc64586..b8ac286dcad6c2f1b4b4b9cb0333cadbf6575ad2 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -290,8 +290,9 @@ class CONTENT_EXPORT WebContentsImpl
void ClosePage() override;
RenderWidgetHostView* GetFullscreenRenderWidgetHostView() const override;
SkColor GetThemeColor() const override;
- WebUI* CreateSubframeWebUI(const GURL& url,
- const std::string& frame_name) override;
+ std::unique_ptr<WebUI> CreateSubframeWebUI(
+ const GURL& url,
+ const std::string& frame_name) override;
WebUI* GetWebUI() const override;
WebUI* GetCommittedWebUI() const override;
void SetUserAgentOverride(const std::string& override) override;
@@ -1100,7 +1101,8 @@ class CONTENT_EXPORT WebContentsImpl
// used to determine which WebUI should be created (if any). |frame_name|
// corresponds to the name of a frame that the WebUI should be created for (or
// the main frame if empty).
- WebUI* CreateWebUI(const GURL& url, const std::string& frame_name);
+ std::unique_ptr<WebUIImpl> CreateWebUI(const GURL& url,
+ const std::string& frame_name);
void SetJavaScriptDialogManagerForTesting(
JavaScriptDialogManager* dialog_manager);
« no previous file with comments | « chrome/browser/ui/webui/uber/uber_ui.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698