Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2439273002: Clean up ownership in WebUI creation. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 const base::Callback<void(RenderFrameHost*)>& on_frame) override; 283 const base::Callback<void(RenderFrameHost*)>& on_frame) override;
284 std::vector<RenderFrameHost*> GetAllFrames() override; 284 std::vector<RenderFrameHost*> GetAllFrames() override;
285 int SendToAllFrames(IPC::Message* message) override; 285 int SendToAllFrames(IPC::Message* message) override;
286 RenderViewHostImpl* GetRenderViewHost() const override; 286 RenderViewHostImpl* GetRenderViewHost() const override;
287 int GetRoutingID() const override; 287 int GetRoutingID() const override;
288 RenderWidgetHostView* GetRenderWidgetHostView() const override; 288 RenderWidgetHostView* GetRenderWidgetHostView() const override;
289 RenderWidgetHostView* GetTopLevelRenderWidgetHostView() override; 289 RenderWidgetHostView* GetTopLevelRenderWidgetHostView() override;
290 void ClosePage() override; 290 void ClosePage() override;
291 RenderWidgetHostView* GetFullscreenRenderWidgetHostView() const override; 291 RenderWidgetHostView* GetFullscreenRenderWidgetHostView() const override;
292 SkColor GetThemeColor() const override; 292 SkColor GetThemeColor() const override;
293 WebUI* CreateSubframeWebUI(const GURL& url, 293 std::unique_ptr<WebUI> CreateSubframeWebUI(
294 const std::string& frame_name) override; 294 const GURL& url,
295 const std::string& frame_name) override;
295 WebUI* GetWebUI() const override; 296 WebUI* GetWebUI() const override;
296 WebUI* GetCommittedWebUI() const override; 297 WebUI* GetCommittedWebUI() const override;
297 void SetUserAgentOverride(const std::string& override) override; 298 void SetUserAgentOverride(const std::string& override) override;
298 const std::string& GetUserAgentOverride() const override; 299 const std::string& GetUserAgentOverride() const override;
299 void EnableTreeOnlyAccessibilityMode() override; 300 void EnableTreeOnlyAccessibilityMode() override;
300 bool IsTreeOnlyAccessibilityModeForTesting() const override; 301 bool IsTreeOnlyAccessibilityModeForTesting() const override;
301 bool IsFullAccessibilityModeForTesting() const override; 302 bool IsFullAccessibilityModeForTesting() const override;
302 const PageImportanceSignals& GetPageImportanceSignals() const override; 303 const PageImportanceSignals& GetPageImportanceSignals() const override;
303 const base::string16& GetTitle() const override; 304 const base::string16& GetTitle() const override;
304 void UpdateTitleForEntry(NavigationEntry* entry, 305 void UpdateTitleForEntry(NavigationEntry* entry,
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
1093 1094
1094 // Helper method that's called whenever |preferred_size_| or 1095 // Helper method that's called whenever |preferred_size_| or
1095 // |preferred_size_for_capture_| changes, to propagate the new value to the 1096 // |preferred_size_for_capture_| changes, to propagate the new value to the
1096 // |delegate_|. 1097 // |delegate_|.
1097 void OnPreferredSizeChanged(const gfx::Size& old_size); 1098 void OnPreferredSizeChanged(const gfx::Size& old_size);
1098 1099
1099 // Internal helper to create WebUI objects associated with |this|. |url| is 1100 // Internal helper to create WebUI objects associated with |this|. |url| is
1100 // used to determine which WebUI should be created (if any). |frame_name| 1101 // used to determine which WebUI should be created (if any). |frame_name|
1101 // corresponds to the name of a frame that the WebUI should be created for (or 1102 // corresponds to the name of a frame that the WebUI should be created for (or
1102 // the main frame if empty). 1103 // the main frame if empty).
1103 WebUI* CreateWebUI(const GURL& url, const std::string& frame_name); 1104 std::unique_ptr<WebUIImpl> CreateWebUI(const GURL& url,
1105 const std::string& frame_name);
1104 1106
1105 void SetJavaScriptDialogManagerForTesting( 1107 void SetJavaScriptDialogManagerForTesting(
1106 JavaScriptDialogManager* dialog_manager); 1108 JavaScriptDialogManager* dialog_manager);
1107 1109
1108 // Returns the FindRequestManager, or creates one if it doesn't already exist. 1110 // Returns the FindRequestManager, or creates one if it doesn't already exist.
1109 FindRequestManager* GetOrCreateFindRequestManager(); 1111 FindRequestManager* GetOrCreateFindRequestManager();
1110 1112
1111 // Removes a registered WebContentsBindingSet by interface name. 1113 // Removes a registered WebContentsBindingSet by interface name.
1112 void RemoveBindingSet(const std::string& interface_name); 1114 void RemoveBindingSet(const std::string& interface_name);
1113 1115
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
1454 // Adds/removes a callback called on creation of each new WebContents. 1456 // Adds/removes a callback called on creation of each new WebContents.
1455 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1457 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1456 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1458 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1457 1459
1458 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1460 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1459 }; 1461 };
1460 1462
1461 } // namespace content 1463 } // namespace content
1462 1464
1463 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1465 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/uber/uber_ui.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698