[Findit] Updating flakiness dashboard to be able to triage results

[Findit] Updating flakiness dashboard to be able to triage results

Example page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

Improvements:
- Fields entered into filter by (i.e. master name, builder name, build_number, etc) now persist when the page is reloaded
- use the &triage=1 flag for Findit sheriffs to also be able to filter by request time
- All build numbers now work as links to the original build failure pages
- Ability to filter by triage status: Found correct, found incorrect, etc. just like in list-analyses
- Overall improved layout/cleaner look and feel


BUG=658041
Committed: https://chromium.googlesource.com/infra/infra/+/2afa29e40ab328f563326f7055bbb6b01dc54acc

[lijeffrey, 2016-10-20 22:23:22]

Description was changed from

==========
[Findit] Updating flakiness dashboard to be able to triage results

BUG=
==========

to

==========
[Findit] Updating flakiness dashboard to be able to triage results

Example page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

append the &triage=1 flag to the url to filter by date

BUG=658041
==========

[lijeffrey, 2016-10-20 22:23:23]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, stgao@chromium.org

[lijeffrey, 2016-10-20 22:23:54]

New flakiness dashboard, check it out!

In the process of adding tests, ptal when you have the chance :)

[lijeffrey, 2016-10-21 00:08:16]

Description was changed from

==========
[Findit] Updating flakiness dashboard to be able to triage results

Example page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

append the &triage=1 flag to the url to filter by date

BUG=658041
==========

to

==========
[Findit] Updating flakiness dashboard to be able to triage results

Example page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

Improvements:
- Fields entered into filter by (i.e. master name, builder name, build_number,
etc) now persist when the page is reloaded
- use the &triage=1 flag for Findit sheriffs to also be able to filter by
request time
- All build numbers now work as links to the original build failure pages
- Ability to filter by triage status: Found correct, found incorrect, etc. just
like in list-analyses
- Overall improved layout/cleaner look and feel


BUG=658041
==========

[lijeffrey, 2016-10-21 00:08:53]

tests added, ptal :)

[chanli, 2016-10-21 05:49:28]

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
File appengine/findit/handlers/flake/list_flakes.py (right):

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:54: def
_GetStartAndEndDates(self, triage):  # pragma: no cover
Add tests? Or you just forgot to remove that pragma: no cover?

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:68: midnight_tomorrow)
Question: it seems that if I have triage=1 and I want to filter all analysis of
a master, I can only get data from yesterday? Of course I can remove triage=1,
but it seems a littler strange...

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:73: status_code =
int(self.request.get('result_status', '-1'))
Is -1 result_status.UNSPECIFIED?

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/model/...
File appengine/findit/model/flake/master_flake_analysis.py (right):

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis.py:76: if triage_result ==
triage_status.TRIAGED_CORRECT:
What's the necessity of using triage_status here?

[lijeffrey, 2016-10-21 20:02:01]

comments addressed, ptal

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
File appengine/findit/handlers/flake/list_flakes.py (right):

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:54: def
_GetStartAndEndDates(self, triage):  # pragma: no cover
On 2016/10/21 05:49:28, chanli wrote:
> Add tests? Or you just forgot to remove that pragma: no cover?

Done.

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:68: midnight_tomorrow)
On 2016/10/21 05:49:28, chanli wrote:
> Question: it seems that if I have triage=1 and I want to filter all analysis
of
> a master, I can only get data from yesterday? Of course I can remove triage=1,
> but it seems a littler strange...

triage=1 only makes it so the date picker shows up, you can also change the
dates in the UI and filter by master too, assuming the update to index.yaml
indeed fixes the indexing exception that happens right now

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:73: status_code =
int(self.request.get('result_status', '-1'))
On 2016/10/21 05:49:28, chanli wrote:
> Is -1 result_status.UNSPECIFIED?

Done.

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/model/...
File appengine/findit/model/flake/master_flake_analysis.py (right):

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis.py:76: if triage_result ==
triage_status.TRIAGED_CORRECT:
On 2016/10/21 05:49:28, chanli wrote:
> What's the necessity of using triage_status here?  

So there are 2 fields, 1 is triage_result and result_status. triage_result is
for an individual CL/suspected flake, result_status is for the entire analysis.
In the case of flake analysis, there is only 1 suspected flake so it's triage
result can be used automatically to determine overall analysis' result_status.
result_status is needed to be kept separately in case there is no suspected
flake and we can still mark it as correct/incorrect not found etc. The code here
just does the automatic updating of result_status too depending on what
triage_result is being passed in.

[chanli, 2016-10-21 22:50:59]

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
File appengine/findit/handlers/flake/list_flakes.py (right):

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:68: midnight_tomorrow)
On 2016/10/21 20:02:01, lijeffrey wrote:
> On 2016/10/21 05:49:28, chanli wrote:
> > Question: it seems that if I have triage=1 and I want to filter all analysis
> of
> > a master, I can only get data from yesterday? Of course I can remove
triage=1,
> > but it seems a littler strange...
> 
> triage=1 only makes it so the date picker shows up, you can also change the
> dates in the UI and filter by master too, assuming the update to index.yaml
> indeed fixes the indexing exception that happens right now

I just checked, so if I add triage=1, I can only get data from yesterday to
tomorrow. I guess what I'm trying to say is we don't need the upper bound and
lower bound when user doesn't specify the dates.

[lijeffrey, 2016-10-23 23:45:09]

On 2016/10/21 22:50:59, chanli wrote:
>
https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
> File appengine/findit/handlers/flake/list_flakes.py (right):
> 
>
https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
> appengine/findit/handlers/flake/list_flakes.py:68: midnight_tomorrow)
> On 2016/10/21 20:02:01, lijeffrey wrote:
> > On 2016/10/21 05:49:28, chanli wrote:
> > > Question: it seems that if I have triage=1 and I want to filter all
analysis
> > of
> > > a master, I can only get data from yesterday? Of course I can remove
> triage=1,
> > > but it seems a littler strange...
> > 
> > triage=1 only makes it so the date picker shows up, you can also change the
> > dates in the UI and filter by master too, assuming the update to index.yaml
> > indeed fixes the indexing exception that happens right now
> 
> I just checked, so if I add triage=1, I can only get data from yesterday to
> tomorrow. I guess what I'm trying to say is we don't need the upper bound and
> lower bound when user doesn't specify the dates.

Oh I think I understand what you mean now. On try job dashboard, there is a
"submit" button. Here to simplify the UI, the "Filter" button under
master/builder/build number/etc. will also take into consideration the dates so
you can change the dates and press "Filter" and get the results for the
specified date range. By default I think for triage=1 since it's primarily for
Findit sheriffing we still want to default to yesterday/today's results, except
on Monday we'll have to change the calendar entry to go back 2 more days and hit
"Filter."

[lijeffrey, 2016-10-23 23:52:35]

Fixed the UI to put the dates under the other flake fields to make the "Filter"
button more obvious that it also handles the start/end dates.
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes?triage=1
to see what it looks like if it's more intuitive to use

ptal :)

[chanli, 2016-10-24 20:53:01]

On 2016/10/23 23:52:35, lijeffrey wrote:
> Fixed the UI to put the dates under the other flake fields to make the
"Filter"
> button more obvious that it also handles the start/end dates.
> https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes?triage=1
> to see what it looks like if it's more intuitive to use
> 
> ptal :)

lgtm with a nit

[chanli, 2016-10-24 20:53:27]

lgtm with a nit

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
File appengine/findit/handlers/flake/list_flakes.py (right):

https://codereview.chromium.org/2435013005/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:68: midnight_tomorrow)
On 2016/10/21 22:50:59, chanli wrote:
> On 2016/10/21 20:02:01, lijeffrey wrote:
> > On 2016/10/21 05:49:28, chanli wrote:
> > > Question: it seems that if I have triage=1 and I want to filter all
analysis
> > of
> > > a master, I can only get data from yesterday? Of course I can remove
> triage=1,
> > > but it seems a littler strange...
> > 
> > triage=1 only makes it so the date picker shows up, you can also change the
> > dates in the UI and filter by master too, assuming the update to index.yaml
> > indeed fixes the indexing exception that happens right now
> 
> I just checked, so if I add triage=1, I can only get data from yesterday to
> tomorrow. I guess what I'm trying to say is we don't need the upper bound and
> lower bound when user doesn't specify the dates.

Acknowledged.

https://codereview.chromium.org/2435013005/diff/60001/appengine/findit/templa...
File appengine/findit/templates/flake/dashboard.html (right):

https://codereview.chromium.org/2435013005/diff/60001/appengine/findit/templa...
appengine/findit/templates/flake/dashboard.html:108: {% if triage %}
Nit: Add a <br> here

[lijeffrey, 2016-10-24 22:36:58]

https://codereview.chromium.org/2435013005/diff/60001/appengine/findit/templa...
File appengine/findit/templates/flake/dashboard.html (right):

https://codereview.chromium.org/2435013005/diff/60001/appengine/findit/templa...
appengine/findit/templates/flake/dashboard.html:108: {% if triage %}
On 2016/10/24 20:53:27, chanli wrote:
> Nit: Add a <br> here

Done.

[lijeffrey, 2016-10-24 22:37:02]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-10-24 22:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org
Link to the patchset: https://codereview.chromium.org/2435013005/#ps80001
(title: "Fixing nit")

[commit-bot: I haz the power, 2016-10-24 22:37:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:52:10]

Description was changed from

==========
[Findit] Updating flakiness dashboard to be able to triage results

Example page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

Improvements:
- Fields entered into filter by (i.e. master name, builder name, build_number,
etc) now persist when the page is reloaded
- use the &triage=1 flag for Findit sheriffs to also be able to filter by
request time
- All build numbers now work as links to the original build failure pages
- Ability to filter by triage status: Found correct, found incorrect, etc. just
like in list-analyses
- Overall improved layout/cleaner look and feel


BUG=658041
==========

to

==========
[Findit] Updating flakiness dashboard to be able to triage results

Example page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

Improvements:
- Fields entered into filter by (i.e. master name, builder name, build_number,
etc) now persist when the page is reloaded
- use the &triage=1 flag for Findit sheriffs to also be able to filter by
request time
- All build numbers now work as links to the original build failure pages
- Ability to filter by triage status: Found correct, found incorrect, etc. just
like in list-analyses
- Overall improved layout/cleaner look and feel


BUG=658041

Committed:
https://chromium.googlesource.com/infra/infra/+/2afa29e40ab328f563326f7055bbb...
==========

[commit-bot: I haz the power, 2016-10-24 22:52:11]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/2afa29e40ab328f563326f7055bbb...