Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3034)

Unified Diff: appengine/findit/waterfall/flake/recursive_flake_pipeline.py

Issue 2435013005: [Findit] Updating flakiness dashboard to be able to triage results (Closed)
Patch Set: Fixing nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/flake/recursive_flake_pipeline.py
diff --git a/appengine/findit/waterfall/flake/recursive_flake_pipeline.py b/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
index 465eaeeec9d8642dfd8f15d4373862e7d82bb093..e72230c73bda6b4790ebce9f16be19c56cf72d04 100644
--- a/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
+++ b/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
@@ -2,8 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import logging
from datetime import timedelta
+import logging
import random
from common import appengine_util
@@ -12,6 +12,7 @@ from common import time_util
from common.pipeline_wrapper import BasePipeline
from model import analysis_status
+from model import result_status
from model.flake.flake_swarming_task import FlakeSwarmingTask
from model.flake.master_flake_analysis import MasterFlakeAnalysis
from waterfall import waterfall_config
@@ -28,6 +29,11 @@ def _UpdateAnalysisStatusUponCompletion(master_flake_analysis, status, error):
if error:
master_flake_analysis.error = error
+ if master_flake_analysis.suspected_flake_build_number is not None:
+ master_flake_analysis.result_status = result_status.FOUND_UNTRIAGED
+ else:
+ master_flake_analysis.result_status = result_status.NOT_FOUND_UNTRIAGED
+
master_flake_analysis.put()
@@ -235,10 +241,11 @@ class NextBuildNumberPipeline(BasePipeline):
master_flake_analysis = MasterFlakeAnalysis.GetVersion(
master_name, builder_name, master_build_number, step_name, test_name,
version=version_number)
- # Don't call another pipeline if we fail.
+
flake_swarming_task = FlakeSwarmingTask.Get(
master_name, builder_name, run_build_number, step_name, test_name)
+ # Don't call another pipeline if we fail.
if flake_swarming_task.status == analysis_status.ERROR:
# TODO(lijeffrey): Implement more detailed error detection and reporting,
# such as timeouts, dead bots, etc.

Powered by Google App Engine
This is Rietveld 408576698