Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: appengine/findit/model/flake/master_flake_analysis.py

Issue 2435013005: [Findit] Updating flakiness dashboard to be able to triage results (Closed)
Patch Set: Fixing nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/master_flake_analysis.py
diff --git a/appengine/findit/model/flake/master_flake_analysis.py b/appengine/findit/model/flake/master_flake_analysis.py
index faa9d0bd44fe7157e0569b399b46001366e50c94..9dc32ed4c759455898e6d2333a7f5a3e699931bf 100644
--- a/appengine/findit/model/flake/master_flake_analysis.py
+++ b/appengine/findit/model/flake/master_flake_analysis.py
@@ -6,6 +6,8 @@ import base64
from google.appengine.ext import ndb
+from model import result_status
+from model import triage_status
from model.base_analysis import BaseAnalysis
from model.base_build_model import BaseBuildModel
from model.flake.flake_swarming_task import FlakeSwarmingTaskData
@@ -66,6 +68,16 @@ class MasterFlakeAnalysis(
master_name, builder_name, build_number, step_name, test_name),
version=version)
+ def UpdateTriageResult(self, triage_result, suspect_info, user_name,
+ version_number=None):
+ super(MasterFlakeAnalysis, self).UpdateTriageResult(
+ triage_result, suspect_info, user_name, version_number=version_number)
+
+ if triage_result == triage_status.TRIAGED_CORRECT:
+ self.result_status = result_status.FOUND_CORRECT
+ else:
+ self.result_status = result_status.FOUND_INCORRECT
+
def Reset(self):
super(MasterFlakeAnalysis, self).Reset()
self.swarming_rerun_results = []
@@ -75,6 +87,7 @@ class MasterFlakeAnalysis(
self.algorithm_parameters = None
self.suspected_flake_build_number = None
self.data_points = []
+ self.result_status = None
# A list of dicts containing information about each swarming rerun's results
# that were involved in this analysis. The contents of this list will be used
@@ -121,3 +134,7 @@ class MasterFlakeAnalysis(
# Who triggered the analysis. Used for differentiating between manual and
# automatic runs, and determining the most active users to gather feedback.
triggering_user_email = ndb.StringProperty(default=None, indexed=False)
+
+ # Overall conclusion of analysis result for the flake. Found untriaged, Found
+ # Correct, etc. used to filter what is displayed on the check flake dashboard.
+ result_status = ndb.IntegerProperty(indexed=True)
« no previous file with comments | « appengine/findit/model/base_triaged_model.py ('k') | appengine/findit/model/flake/test/master_flake_analysis_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698