Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: appengine/findit/model/flake/test/master_flake_analysis_test.py

Issue 2435013005: [Findit] Updating flakiness dashboard to be able to triage results (Closed)
Patch Set: Fixing nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/model/flake/master_flake_analysis.py ('k') | appengine/findit/model/result_status.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/flake/test/master_flake_analysis_test.py
diff --git a/appengine/findit/model/flake/test/master_flake_analysis_test.py b/appengine/findit/model/flake/test/master_flake_analysis_test.py
index aff35faee5957634641f974dfcb6433c4f7569b5..edc5e946dc0f51c58ac10160454a1782632e7d5f 100644
--- a/appengine/findit/model/flake/test/master_flake_analysis_test.py
+++ b/appengine/findit/model/flake/test/master_flake_analysis_test.py
@@ -7,6 +7,8 @@ from datetime import datetime
import unittest
from model import analysis_status
+from model import result_status
+from model import triage_status
from model.flake.master_flake_analysis import DataPoint
from model.flake.master_flake_analysis import MasterFlakeAnalysis
@@ -86,6 +88,18 @@ class MasterFlakeAnalysisTest(unittest.TestCase):
self.assertEqual('s', analysis.step_name)
self.assertEqual('t', analysis.test_name)
+ def testMasterFlakeAnalysisUpdateTriageResultCorrect(self):
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+ analysis.UpdateTriageResult(
+ triage_status.TRIAGED_CORRECT, {'build_number': 100}, 'test')
+ self.assertEqual(analysis.result_status, result_status.FOUND_CORRECT)
+
+ def testMasterFlakeAnalysisUpdateTriageResultIncorrect(self):
+ analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
+ analysis.UpdateTriageResult(
+ triage_status.TRIAGED_INCORRECT, {'build_number': 100}, 'test')
+ self.assertEqual(analysis.result_status, result_status.FOUND_INCORRECT)
+
def testReset(self):
analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
analysis.swarming_rerun_results = [{}]
« no previous file with comments | « appengine/findit/model/flake/master_flake_analysis.py ('k') | appengine/findit/model/result_status.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698