Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 243473002: Make window.showModalDialog configurable at runtime (Closed)

Created:
6 years, 8 months ago by abarth-chromium
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, shans, apavlov+blink_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, caseq+blink_chromium.org, Steve Block, arv+blink, alancutter (OOO until 2018), pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, rjwright, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Make window.showModalDialog configurable at runtime This CL makes it possible to enable and disable showModalDialog with a runtime flag. Currently, the flag is enabled in stable, but we'll likely change that at some point soon. BUG=345831 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171964

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 8 months ago (2014-04-18 18:01:12 UTC) #1
eseidel
lgtm
6 years, 8 months ago (2014-04-18 18:02:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/243473002/1
6 years, 8 months ago (2014-04-18 18:02:16 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 19:10:36 UTC) #4
Message was sent while issue was closed.
Change committed as 171964

Powered by Google App Engine
This is Rietveld 408576698