Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(785)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt
Issue
243473002
:
Make window.showModalDialog configurable at runtime (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set:
Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt
LayoutTests/fast/dom/Window/open-window-min-size-expected.txt
LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt
LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt
LayoutTests/fast/harness/show-modal-dialog-expected.txt
LayoutTests/inspector/console/console-long-eval-crash-expected.txt
LayoutTests/platform/mac/fast/dom/Window/open-window-min-size-expected.txt
Source/core/frame/UseCounter.cpp
Source/core/frame/Window.idl
Source/platform/RuntimeEnabledFeatures.in
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt
('k') |
LayoutTests/fast/harness/show-modal-dialog-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
CONSOLE WARNING:
Chromium
is
considering deprecating showModalDialog
. Please use
window.open and postMessage instead.
1
CONSOLE WARNING:
showModalDialog
is
deprecated
. Please use window.open and postM
essage instead.
2 Pop up a modal dialog. Verifies that focus events are not fired while inside the message loop.
2 Pop up a modal dialog. Verifies that focus events are not fired while inside the message loop.
3
3
4
4
5 You need to disable pop-up blocker for this test to run successfully in the brow ser.
5 You need to disable pop-up blocker for this test to run successfully in the brow ser.
6
6
7 onblur fired. Should see this exactly once.
7 onblur fired. Should see this exactly once.
8 Modal dialog closing.
8 Modal dialog closing.
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt
('k') |
LayoutTests/fast/harness/show-modal-dialog-expected.txt »
('j') |
no next file with comments »
Issue 243473002: Make window.showModalDialog configurable at runtime (Closed)
Created 6 years, 8 months ago by abarth-chromium
Modified 6 years, 8 months ago
Reviewers: eseidel
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 243473002:
Make window.showModalDialog configurable at runtime (Closed)
Base URL: svn://svn.chromium.org/blink/trunk