Source/core/frame/UseCounter.cpp - Issue 243473002: Make window.showModalDialog configurable at runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 243473002: Make window.showModalDialog configurable at runtime (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/UseCounter.cpp

diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp

index decf0a1c79281adf204f0eacade3e89615397dd2..d2dce20b1b4270cd89632c979074c06e2a7fade3 100644

--- a/Source/core/frame/UseCounter.cpp

+++ b/Source/core/frame/UseCounter.cpp

@@ -660,7 +660,7 @@ String UseCounter::deprecationMessage(Feature feature)

return "FileError is deprecated. Please use the 'name' or 'message' attributes of DOMError rather than 'code'.";

case ShowModalDialog:

- return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead.";

+ return "showModalDialog is deprecated. Please use window.open and postMessage instead.";

case CSSStyleSheetInsertRuleOptionalArg:

return "Calling CSSStyleSheet.insertRule() with one argument is deprecated. Please pass the index argument as well: insertRule(x, 0).";