Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2434643002: Subzero: Fix compiler warnings. (Closed)

Created:
4 years, 2 months ago by Jim Stichnoth
Modified:
4 years, 2 months ago
Reviewers:
capn, John, nicolascapens
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix compiler warnings. src/IceTargetLoweringX86BaseImpl.h:6093:13: error: unused variable 'Src1RM' [-Werror,-Wunused-variable] auto *Src1RM = legalize(Src1, Legal_Reg | Legal_Mem); ^ src/IceTargetLoweringX86BaseImpl.h:4007:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default] default: ^ src/IceTargetLoweringMIPS32.cpp:4065:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default] default: ^ src/IceTargetLoweringARM32.cpp:4975:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default] default: ^ BUG= none R=capn@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7145e69306813c75e1d9260ed468c266f9e038f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M src/IceTargetLoweringARM32.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 2 months ago (2016-10-19 06:20:00 UTC) #3
capn
LGTM
4 years, 2 months ago (2016-10-19 06:23:56 UTC) #4
Jim Stichnoth
4 years, 2 months ago (2016-10-19 12:49:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7145e69306813c75e1d9260ed468c266f9e038f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698