Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243413002: Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData. (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData. BUG=skia:2402 Committed: http://code.google.com/p/skia/source/detail?r=14533 Committed: http://code.google.com/p/skia/source/detail?r=14564

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : some cleanup #

Patch Set 4 : upload again, rietveld diff failed. #

Patch Set 5 : rebase to tot #

Patch Set 6 : rebase on 258693008 #

Patch Set 7 : rebase #

Patch Set 8 : fix assert #

Total comments: 13

Patch Set 9 : Address Rob's comments #

Patch Set 10 : shut up warning: #

Patch Set 11 : revert revert #

Patch Set 12 : fix case #

Patch Set 13 : rebase to tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -63 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +26 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 1 2 3 4 5 6 7 8 2 chunks +16 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +79 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 3 4 5 6 7 8 5 chunks +16 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 5 6 7 8 6 chunks +35 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 2 3 4 5 6 6 chunks +31 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 3 4 5 6 7 8 3 chunks +12 lines, -4 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 2 3 4 5 6 2 chunks +13 lines, -1 line 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrBufferObj.h View 2 chunks +10 lines, -2 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 2 3 4 5 6 7 8 9 9 chunks +68 lines, -14 lines 0 comments Download
M src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
bsalomon
6 years, 7 months ago (2014-05-01 20:46:09 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/243413002/diff/130001/src/gpu/GrDrawTargetCaps.h File src/gpu/GrDrawTargetCaps.h (right): https://codereview.chromium.org/243413002/diff/130001/src/gpu/GrDrawTargetCaps.h#newcode52 src/gpu/GrDrawTargetCaps.h:52: kCanMap_MapFlag = 0x1, //<! The resource ...
6 years, 7 months ago (2014-05-02 12:57:30 UTC) #2
bsalomon
https://codereview.chromium.org/243413002/diff/130001/src/gpu/GrDrawTargetCaps.h File src/gpu/GrDrawTargetCaps.h (right): https://codereview.chromium.org/243413002/diff/130001/src/gpu/GrDrawTargetCaps.h#newcode52 src/gpu/GrDrawTargetCaps.h:52: kCanMap_MapFlag = 0x1, //<! The resource can be mapped. ...
6 years, 7 months ago (2014-05-02 14:44:22 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-05-02 14:44:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/243413002/150001
6 years, 7 months ago (2014-05-02 14:44:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 14:50:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildTests, BuildTools http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?builder=Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot&number=2278
6 years, 7 months ago (2014-05-02 14:50:34 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-05-02 14:57:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/243413002/170001
6 years, 7 months ago (2014-05-02 14:58:08 UTC) #9
commit-bot: I haz the power
Change committed as 14533
6 years, 7 months ago (2014-05-02 15:08:31 UTC) #10
djsollen
This is failing to compile on iOS. If you have a quick fix go ahead ...
6 years, 7 months ago (2014-05-02 16:01:33 UTC) #11
bsalomon
On 2014/05/02 16:01:33, djsollen wrote: > This is failing to compile on iOS. If you ...
6 years, 7 months ago (2014-05-02 16:10:16 UTC) #12
djsollen
A revert of this CL has been created in https://codereview.chromium.org/262963002/ by djsollen@google.com. The reason for ...
6 years, 7 months ago (2014-05-02 17:37:13 UTC) #13
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-05-05 12:26:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/243413002/220001
6 years, 7 months ago (2014-05-05 12:26:38 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 12:32:43 UTC) #16
Message was sent while issue was closed. 
Change committed as 14564

Powered by Google App Engine
This is Rietveld 408576698