[Android] Change object types from AndroidCommands to DeviceUtils everywhere else.

[Android] Change object types from AndroidCommands to DeviceUtils everywhere else.

BUG=267773
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266818

[craigdh, 2014-04-21 19:56:54]

chrome/test/chromedriver/ lgtm

[bulach, 2014-04-22 14:59:43]

lgtm, make sure the try bots are happy.

also, maybe send a PSA, just in case? I'm not sure we ever told the team about
the plans, so it may a good idea to give a heads up and let people know about
this... wdyt?

https://codereview.chromium.org/243403003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/243403003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:89:
self.adb.device().old_interface.PushIfNeeded(
gargh. :)
understand adding this new indirection is temporary, but I'm very much looking
forward to remove some of these interfaces soon!! :)

[jbudorick, 2014-04-22 15:10:47]

On 2014/04/22 14:59:43, bulach wrote:
> lgtm, make sure the try bots are happy.

This is definitely not a NOTRY patch.

> 
> also, maybe send a PSA, just in case? I'm not sure we ever told the team about
> the plans, so it may a good idea to give a heads up and let people know about
> this... wdyt?

After all of the fun that resulted from landing the last patch, that seems like
an excellent idea.

> 
>
https://codereview.chromium.org/243403003/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
> (right):
> 
>
https://codereview.chromium.org/243403003/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:89:
> self.adb.device().old_interface.PushIfNeeded(
> gargh. :)
> understand adding this new indirection is temporary, but I'm very much looking
> forward to remove some of these interfaces soon!! :)

Me too. It's particularly bad here in telemetry, which already had its own
wrapper around AndroidCommands.

[tonyg, 2014-04-28 16:28:06]

On 2014/04/22 15:10:47, jbudorick wrote:
> On 2014/04/22 14:59:43, bulach wrote:
> > lgtm, make sure the try bots are happy.
> 
> This is definitely not a NOTRY patch.

lgtm

Thanks for holding off during the fixit. Thanks to Armand, we now have nascent
main waterfall and cq coverage of Telemetry unittests on android so you should
know if anything breaks too terribly. Unfortunately, I noticed a few places that
will need a non-trivial rebase. But feel free to just CQ after it is merged.

>
https://codereview.chromium.org/243403003/diff/20001/tools/telemetry/telemetr...
> > File
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
> > (right):
> > 
> >
>
https://codereview.chromium.org/243403003/diff/20001/tools/telemetry/telemetr...
> >
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:89:
> > self.adb.device().old_interface.PushIfNeeded(
> > gargh. :)
> > understand adding this new indirection is temporary, but I'm very much
looking
> > forward to remove some of these interfaces soon!! :)
> 
> Me too. It's particularly bad here in telemetry, which already had its own
> wrapper around AndroidCommands.

+1, this is really ugly, but I'm okay with just closing my eyes and rubber
stamping during your refactoring.

[jbudorick, 2014-04-29 00:04:33]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-04-29 00:08:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbudorick@chromium.org/243403003/40001

[commit-bot: I haz the power, 2014-04-29 00:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 00:46:25]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[jbudorick, 2014-04-29 01:27:38]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:28:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbudorick@chromium.org/243403003/40001

[commit-bot: I haz the power, 2014-04-29 09:58:06]

Change committed as 266818