Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tools/memory_inspector/PRESUBMIT.py

Issue 243403003: [Android] Change object types from AndroidCommands to DeviceUtils everywhere else. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for memory_inspector. 5 """Top-level presubmit script for memory_inspector.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into gcl. 8 details on the presubmit API built into gcl.
9 """ 9 """
10 10
11 11
12 def CommonChecks(input_api, output_api): 12 def CommonChecks(input_api, output_api):
13 output = [] 13 output = []
14 blacklist = [r'classification_rules.*'] 14 blacklist = [r'classification_rules.*']
15 output.extend(input_api.canned_checks.RunPylint( 15 output.extend(input_api.canned_checks.RunPylint(
16 input_api, output_api, black_list=blacklist)) 16 input_api, output_api, black_list=blacklist,
17 extra_paths_list=[
18 input_api.os_path.join(input_api.PresubmitLocalPath(), '..', '..',
19 'build', 'android')
20 ]))
17 output.extend(input_api.canned_checks.RunUnitTests( 21 output.extend(input_api.canned_checks.RunUnitTests(
18 input_api, 22 input_api,
19 output_api, 23 output_api,
20 [input_api.os_path.join(input_api.PresubmitLocalPath(), 'run_tests')])) 24 [input_api.os_path.join(input_api.PresubmitLocalPath(), 'run_tests')]))
21 25
22 if input_api.is_committing: 26 if input_api.is_committing:
23 output.extend(input_api.canned_checks.PanProjectChecks(input_api, 27 output.extend(input_api.canned_checks.PanProjectChecks(input_api,
24 output_api, 28 output_api,
25 owners_check=False)) 29 owners_check=False))
26 return output 30 return output
27 31
28 32
29 def CheckChangeOnUpload(input_api, output_api): 33 def CheckChangeOnUpload(input_api, output_api):
30 return CommonChecks(input_api, output_api) 34 return CommonChecks(input_api, output_api)
31 35
32 36
33 def CheckChangeOnCommit(input_api, output_api): 37 def CheckChangeOnCommit(input_api, output_api):
34 return CommonChecks(input_api, output_api) 38 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « tools/android/mempressure.py ('k') | tools/memory_inspector/memory_inspector/backends/android/android_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698