tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py - Issue 243403003: [Android] Change object types from AndroidCommands to DeviceUtils everywhere else.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

Issue 243403003: [Android] Change object types from AndroidCommands to DeviceUtils everywhere else. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py ('k') | tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

index 8820d7d5288ab756f45f64374d053381e037c9ce..e04f65580c8893d8c8c96fd73afb5dbec131f891 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

@@ -34,13 +34,13 @@ class _TCMallocHeapProfilerAndroid(object):

def _SetDeviceProperties(self, properties):

device_configured = False

# This profiler requires adb root to set properties.

- self._browser_backend.adb.Adb().EnableAdbRoot()

+ self._browser_backend.adb.device().old_interface.EnableAdbRoot()

for values in properties.itervalues():

device_property = self._browser_backend.adb.system_properties[values[0]]

if not device_property or not device_property.strip():

self._browser_backend.adb.system_properties[values[0]] = values[1]

device_configured = True

- if not self._browser_backend.adb.Adb().FileExistsOnDevice(

+ if not self._browser_backend.adb.device().old_interface.FileExistsOnDevice(

self._DEFAULT_DEVICE_DIR):

self._browser_backend.adb.RunShellCommand(

'mkdir -p ' + self._DEFAULT_DEVICE_DIR)

@@ -51,7 +51,7 @@ class _TCMallocHeapProfilerAndroid(object):

raise Exception('Device required special config, run again.')

def CollectProfile(self):

- self._browser_backend.adb.Adb().Adb().Pull(

+ self._browser_backend.adb.device().old_interface.Adb().Pull(

self._DEFAULT_DEVICE_DIR, self._output_path)

self._browser_backend.adb.RunShellCommand(

'rm ' + os.path.join(self._DEFAULT_DEVICE_DIR, '*'))