tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py - Issue 243403003: [Android] Change object types from AndroidCommands to DeviceUtils everywhere else.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

Issue 243403003: [Android] Change object types from AndroidCommands to DeviceUtils everywhere else. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py ('k') | tools/telemetry/telemetry/core/platform/profiler/android_screen_recorder_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py b/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

index 17abf08ee7ad015cc906577644fc661236f40408..fa838eafe82563ab5e0857374e8dca68e4c22ec6 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

@@ -19,7 +19,7 @@ def GetDevicePath(profiler_binary):

@decorators.Cache

-def InstallOnDevice(adb, profiler_binary):

+def InstallOnDevice(device, profiler_binary):

host_path = support_binaries.FindPath(profiler_binary, 'android')

if not host_path:

logging.error('Profiler binary "%s" not found. Could not be installed',

@@ -27,6 +27,7 @@ def InstallOnDevice(adb, profiler_binary):

return False

device_binary_path = GetDevicePath(profiler_binary)

- adb.PushIfNeeded(host_path, device_binary_path)

- adb.RunShellCommand('chmod 777 ' + device_binary_path)

+ device.old_interface.PushIfNeeded(host_path, device_binary_path)

+ device.old_interface.RunShellCommand('chmod 777 ' + device_binary_path)

return True