Setup Blimp internal string resources.

Setup Blimp internal string resources.

Previously the 0.6 Chrome/Blimp integrated build still use strings in
//blimp/client/app, which also only generates android strings files.

This CL:
1. Setup strings resources in //blimp/client/core, all core code won't
use app resources anymore.

2. Internal core strings are protected behind the build flag
|enable_blimp_client|, so normal Chrome build won't contain Blimp
internal strings. Also the build flag is only used in
//blimp/client/core build files.

3. The Blimp linux shell only loads the English string pak file. Unit
tests and 0.5 app currently don't depends on the new core strings.

Clean resources bug.
BUG=630687
Decouple app and core code bug.
BUG=651964
Committed: https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957
Cr-Commit-Position: refs/heads/master@{#431484}

[xingliu, 2016-10-18 22:40:09]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 22:40:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 22:51:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 22:51:42]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xingliu, 2016-10-18 23:19:00]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 23:19:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 23:30:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:30:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xingliu, 2016-10-18 23:50:00]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 23:50:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 01:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 01:35:41]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[xingliu, 2016-10-19 01:53:07]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 01:53:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 03:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 03:20:29]

Dry run: Exceeded global retry quota

[xingliu, 2016-10-19 17:37:41]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 17:37:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-19 21:01:09]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org

[xingliu, 2016-10-19 21:01:11]

Currently it has an issue that win_clang trybot will fail, I'm trying to figure
out why.

This CL is the last one for the string setup.

[xingliu, 2016-10-19 21:42:43]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:43:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:59:45]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[xingliu, 2016-10-21 17:45:33]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 17:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 17:51:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 17:51:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xingliu, 2016-10-22 01:12:28]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 01:13:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 02:32:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 02:32:44]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[xingliu, 2016-10-23 03:00:51]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 03:00:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-23 03:14:09]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 03:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 05:15:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 05:15:03]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xingliu, 2016-10-24 16:39:40]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 16:40:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:56:34]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-10-26 00:43:18]

A few comments on the structure of the linux client and how we include the
strings there.  Is there a way we can avoid including client/core here?

lgtm % that investigation and discussion.  Ping me tomorrow around 9:30 am or so
and I should have time to talk for a few :).

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/BUILD.gn
File blimp/client/app/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/BUILD...
blimp/client/app/BUILD.gn:171: repack("pak") {
Why do we need to just pull the english version again?  Is there a target we
could link on that didn't hit internal core/resources directly?

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/blimp...
File blimp/client/app/blimp_startup.cc (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/blimp...
blimp/client/app/blimp_startup.cc:91:
ui::ResourceBundle::InitSharedInstanceWithPakPath(pak_file);
Is the only way to do this through the test methods?  I'm assuming there is no
straightforward path that lets us go through the normal pak load flow?

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
File blimp/client/public/resources/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
blimp/client/public/resources/BUILD.gn:8: visibility = [ "//chrome/*" ]
Should we just remove the visibility if it's meant to be hit by all embedders?

[xingliu, 2016-10-26 18:13:48]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 18:14:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 18:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:18:59]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xingliu, 2016-10-26 19:40:48]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 19:41:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:50:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xingliu, 2016-10-26 20:05:07]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:06:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:11:13]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-26 21:14:42]

Thanks for the feedback, added another target in blimp/client/public/resources,
only for app.

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/BUILD.gn
File blimp/client/app/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/BUILD...
blimp/client/app/BUILD.gn:171: repack("pak") {
On 2016/10/26 00:43:18, David Trainor wrote:
> Why do we need to just pull the english version again?  Is there a target we
> could link on that didn't hit internal core/resources directly?

Added another target in public/resources/BUILD.gn.

Most of the shells use something like this, including content/shell:pak, then
call ui::ResourceBundle::InitSharedInstanceWithPakPath to load the file.
And only load english string data file.

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/blimp...
File blimp/client/app/blimp_startup.cc (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/app/blimp...
blimp/client/app/blimp_startup.cc:91:
ui::ResourceBundle::InitSharedInstanceWithPakPath(pak_file);
On 2016/10/26 00:43:18, David Trainor wrote:
> Is the only way to do this through the test methods?  I'm assuming there is no
> straightforward path that lets us go through the normal pak load flow?

Blimp engine and content shell, ash shell use this method.

There are two other functions used by chrome and mus, probably only for
production code, the one chrome used needs other setup like
chrome_repack_locale.gni, and hard coded file path.

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
File blimp/client/public/resources/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
blimp/client/public/resources/BUILD.gn:8: visibility = [ "//chrome/*" ]
On 2016/10/26 00:43:18, David Trainor wrote:
> Should we just remove the visibility if it's meant to be hit by all embedders?

Actually this target is only for chrome, because in core/resources:strings, we
do special things for enable_blimp_client flag, and the flag is only for chrome.

Added another target in here for blimp/client/app.

[xingliu, 2016-10-26 21:17:57]

xingliu@chromium.org changed reviewers:
+ thakis@chromium.org

[xingliu, 2016-10-26 21:17:58]

thakis@chromium.org: Please help review changes in 

blimp/client/DEPS
build/android/lint/suppressions.xml
chrome/chrome_repack_locales.gni
tools/gritsettings/resource_ids
tools/gritsettings/translation_expectations.pyl
*.gn

Thanks.

[David Trainor- moved to gerrit, 2016-10-28 04:20:08]

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
File blimp/client/public/resources/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
blimp/client/public/resources/BUILD.gn:8: visibility = [ "//chrome/*" ]
On 2016/10/26 21:14:42, xingliu wrote:
> On 2016/10/26 00:43:18, David Trainor wrote:
> > Should we just remove the visibility if it's meant to be hit by all
embedders?
> 
> Actually this target is only for chrome, because in core/resources:strings, we
> do special things for enable_blimp_client flag, and the flag is only for
chrome.
> 
> Added another target in here for blimp/client/app.

Why is it only for chrome?  We have to set enable_blimp_client for any embedder
right?

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/app/BUILD.gn
File blimp/client/app/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/app/BUILD...
blimp/client/app/BUILD.gn:177: "//blimp/client/public/resources:app_strings",
Can we call this something that sounds test/shell related?  Maybe shell_strings?

Not sure I like this approach better actually, but I don't have a good
suggestion, so I'm ok with it.

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/public/re...
File blimp/client/public/resources/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/public/re...
blimp/client/public/resources/BUILD.gn:7: group("strings") {
Leave this as resources

[xingliu, 2016-10-28 21:24:50]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 21:25:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 22:28:57]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-28 22:50:31]

Thanks for the feedback, did some polish on naming.

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
File blimp/client/public/resources/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/240001/blimp/client/public/re...
blimp/client/public/resources/BUILD.gn:8: visibility = [ "//chrome/*" ]
On 2016/10/28 04:20:08, David Trainor (OOO to oct 31) wrote:
> On 2016/10/26 21:14:42, xingliu wrote:
> > On 2016/10/26 00:43:18, David Trainor wrote:
> > > Should we just remove the visibility if it's meant to be hit by all
> embedders?
> > 
> > Actually this target is only for chrome, because in core/resources:strings,
we
> > do special things for enable_blimp_client flag, and the flag is only for
> chrome.
> > 
> > Added another target in here for blimp/client/app.
> 
> Why is it only for chrome?  We have to set enable_blimp_client for any
embedder
> right?

Yes, but for blimp_shell it's directly depend on core/*, so if we let it go
through the target that checks |enable_blimp_client|, it might hit the scenario
that it didn't load the string but try to access the string.

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/app/BUILD.gn
File blimp/client/app/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/app/BUILD...
blimp/client/app/BUILD.gn:177: "//blimp/client/public/resources:app_strings",
On 2016/10/28 04:20:08, David Trainor (OOO to oct 31) wrote:
> Can we call this something that sounds test/shell related?  Maybe
shell_strings?
> 
> Not sure I like this approach better actually, but I don't have a good
> suggestion, so I'm ok with it.

Done.

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/public/re...
File blimp/client/public/resources/BUILD.gn (right):

https://codereview.chromium.org/2431653004/diff/260001/blimp/client/public/re...
blimp/client/public/resources/BUILD.gn:7: group("strings") {
On 2016/10/28 04:20:08, David Trainor (OOO to oct 31) wrote:
> Leave this as resources

Done.

[David Trainor- moved to gerrit, 2016-11-02 16:36:33]

lgtm, but we might need to revisit that visibility issue later.  I'm fine with
landing this now though.

[xingliu, 2016-11-08 19:18:00]

Friendly ping.

[Nico, 2016-11-10 20:58:46]

lgtm (sorry, have been traveling)

[xingliu, 2016-11-10 23:49:31]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 23:50:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 00:11:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 00:11:44]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[xingliu, 2016-11-11 00:34:51]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 00:35:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:12:05]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[xingliu, 2016-11-11 02:18:29]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 02:18:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 03:29:34]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-11-11 03:33:20]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-11-11 03:33:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2431653004/#ps360001
(title: "Added some recent blimp java xml file.")

[commit-bot: I haz the power, 2016-11-11 03:33:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:43:50]

Committed patchset #19 (id:360001)

[commit-bot: I haz the power, 2016-11-11 03:56:40]

Description was changed from

==========
Setup Blimp internal string resources.

Previously the 0.6 Chrome/Blimp integrated build still use strings in
//blimp/client/app, which also only generates android strings files.

This CL:
1. Setup strings resources in //blimp/client/core, all core code won't
use app resources anymore.

2. Internal core strings are protected behind the build flag
|enable_blimp_client|, so normal Chrome build won't contain Blimp
internal strings. Also the build flag is only used in
//blimp/client/core build files.

3. The Blimp linux shell only loads the English string pak file. Unit
tests and 0.5 app currently don't depends on the new core strings.



Clean resources bug.
BUG=630687

Decouple app and core code bug.
BUG=651964
==========

to

==========
Setup Blimp internal string resources.

Previously the 0.6 Chrome/Blimp integrated build still use strings in
//blimp/client/app, which also only generates android strings files.

This CL:
1. Setup strings resources in //blimp/client/core, all core code won't
use app resources anymore.

2. Internal core strings are protected behind the build flag
|enable_blimp_client|, so normal Chrome build won't contain Blimp
internal strings. Also the build flag is only used in
//blimp/client/core build files.

3. The Blimp linux shell only loads the English string pak file. Unit
tests and 0.5 app currently don't depends on the new core strings.

Clean resources bug.
BUG=630687

Decouple app and core code bug.
BUG=651964

Committed: https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957
Cr-Commit-Position: refs/heads/master@{#431484}
==========

[commit-bot: I haz the power, 2016-11-11 03:56:42]

Patchset 19 (id:??) landed as
https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957
Cr-Commit-Position: refs/heads/master@{#431484}