blimp/client/public/resources/BUILD.gn - Issue 2431653004: Setup Blimp internal string resources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/public/resources/BUILD.gn

Issue 2431653004: Setup Blimp internal string resources. (Closed)

Patch Set: Removed unused entry in public/DEPS Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Resources for the embedder, we build different resource sets based on \|enable_ blimp_client\| build

	6 # flag in //blimp/client/core/resources.

	7 group("resources") {

	8 visibility = [ "//chrome/*" ]
	David Trainor- moved to gerrit 2016/10/26 00:43:18 Should we just remove the visibility if it's meant Should we just remove the visibility if it's meant to be hit by all embedders? xingliu 2016/10/26 21:14:42 Actually this target is only for chrome, because i Show quoted text On 2016/10/26 00:43:18, David Trainor wrote: > Should we just remove the visibility if it's meant to be hit by all embedders? Actually this target is only for chrome, because in core/resources:strings, we do special things for enable_blimp_client flag, and the flag is only for chrome. Added another target in here for blimp/client/app. David Trainor- moved to gerrit 2016/10/28 04:20:08 Why is it only for chrome? We have to set enable_ Show quoted text On 2016/10/26 21:14:42, xingliu wrote: > On 2016/10/26 00:43:18, David Trainor wrote: > > Should we just remove the visibility if it's meant to be hit by all embedders? > > Actually this target is only for chrome, because in core/resources:strings, we > do special things for enable_blimp_client flag, and the flag is only for chrome. > > Added another target in here for blimp/client/app. Why is it only for chrome? We have to set enable_blimp_client for any embedder right? xingliu 2016/10/28 22:50:31 Yes, but for blimp_shell it's directly depend on c Show quoted text On 2016/10/28 04:20:08, David Trainor (OOO to oct 31) wrote: > On 2016/10/26 21:14:42, xingliu wrote: > > On 2016/10/26 00:43:18, David Trainor wrote: > > > Should we just remove the visibility if it's meant to be hit by all > embedders? > > > > Actually this target is only for chrome, because in core/resources:strings, we > > do special things for enable_blimp_client flag, and the flag is only for > chrome. > > > > Added another target in here for blimp/client/app. > > Why is it only for chrome? We have to set enable_blimp_client for any embedder > right? Yes, but for blimp_shell it's directly depend on core/*, so if we let it go through the target that checks \|enable_blimp_client\|, it might hit the scenario that it didn't load the string but try to access the string.
	9

	10 public_deps = [

	11 "//blimp/client/core/resources:strings",

	12 ]

	13 }

OLD	NEW

« blimp/client/app/blimp_startup.cc ('K') | « blimp/client/public/blimp_client_context_delegate.h ('k') | blimp/client/public/resources/blimp_strings.h » ('j') | no next file with comments »