blimp/client/public/resources/BUILD.gn - Issue 2431653004: Setup Blimp internal string resources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/public/resources/BUILD.gn

Issue 2431653004: Setup Blimp internal string resources. (Closed)

Patch Set: Fixes for feedback. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Strings for the embedder, we build different resource sets based on \|enable_bl imp_client\| build

	6 # flag in //blimp/client/core/resources:strings.

	7 group("strings") {
	David Trainor- moved to gerrit 2016/10/28 04:20:08 Leave this as resources Leave this as resources xingliu 2016/10/28 22:50:31 Done. Show quoted text On 2016/10/28 04:20:08, David Trainor (OOO to oct 31) wrote: > Leave this as resources Done.
	8 visibility = [ "//chrome/*" ]

	9

	10 public_deps = [

	11 "//blimp/client/core/resources:strings",

	12 ]

	13 }

	14

	15 # Strings for //blimp/client/app, this target directly builds core strings data and does not check

	16 # the \|enable_blimp_client\| build flag.

	17 group("app_strings") {

	18 visibility = [ "//blimp/client/app/*" ]

	19

	20 public_deps = [

	21 "//blimp/client/core/resources:string_data",

	22 ]

	23 }

OLD	NEW