Introduce BookmarkClient interface to abstract embedder

chrome/browser/bookmarks/bookmark_test_helpers.cc

Index: chrome/browser/bookmarks/bookmark_test_helpers.cc
diff --git a/chrome/browser/bookmarks/bookmark_test_helpers.cc b/chrome/browser/bookmarks/bookmark_test_helpers.cc
index 51870ae68b5948cd0b5c0afbe2be9db837b1cd05..bfb5296ba8516a1691244e1bf35221813791039d 100644
--- a/chrome/browser/bookmarks/bookmark_test_helpers.cc
+++ b/chrome/browser/bookmarks/bookmark_test_helpers.cc
@@ -97,6 +97,44 @@ std::string::size_type AddNodesFromString(BookmarkModel* model,
 
 namespace test {
 
+BookmarkModel* TestBookmarkClient::CreateModel() {
+  scoped_ptr<BookmarkModel> bookmark_model(new BookmarkModel(this));

[tfarina, 2014/04/22 21:19:58]

I don't think using scoped_ptr + release here helps much. I would simply
allocate on the heap and return the raw pointer. Also make sure to document the
ownership in the declaration of CreateModel, saying to clients that
TestBookmarkClient does not own the pointer and the caller is responsible for
releasing the memory after it is done with it.

[sdefresne, 2014/04/23 16:10:18]

Done.

+  bookmark_model->DoneLoading(bookmark_model->CreateLoadDetails());
+  return bookmark_model.release();
+}
+
+base::CancelableTaskTracker::TaskId TestBookmarkClient::GetFaviconImageForURL(
+    const GURL& page_url,
+    int icon_types,
+    int desired_size_in_dip,
+    const FaviconImageCallback& callback,
+    base::CancelableTaskTracker* tracker) {
+  return base::CancelableTaskTracker::kBadTaskId;
+}
+
+bool TestBookmarkClient::SupportsTypedCountForNodes() {
+  return false;
+}
+
+void TestBookmarkClient::GetTypedCountForNodes(
+    const NodeSet& nodes,
+    NodeTypedCountPairs* node_typed_count_pairs) {
+  NOTREACHED();
+}
+
+void TestBookmarkClient::RecordAction(const base::UserMetricsAction& action) {
+}
+
+void TestBookmarkClient::OnLoad() {
+}
+
+void TestBookmarkClient::OnClearStore() {
+}
+
+void TestBookmarkClient::NotifyHistoryAboutRemovedBookmarks(
+    const std::set<GURL>& removed_bookmark_urls) {
+}
+
 void WaitForBookmarkModelToLoad(BookmarkModel* model) {
   if (model->loaded())
     return;