Introduce BookmarkClient interface to abstract embedder

chrome/browser/bookmarks/bookmark_test_helpers.h

Index: chrome/browser/bookmarks/bookmark_test_helpers.h
diff --git a/chrome/browser/bookmarks/bookmark_test_helpers.h b/chrome/browser/bookmarks/bookmark_test_helpers.h
index 7b52cab0a9d1ce90b072c10b26fa2fb41f605a7f..41d7f42acf765fe96a555a8177b65b264864b171 100644
--- a/chrome/browser/bookmarks/bookmark_test_helpers.h
+++ b/chrome/browser/bookmarks/bookmark_test_helpers.h
@@ -7,12 +7,43 @@
 
 #include <string>
 
+#include "components/bookmarks/core/browser/bookmark_client.h"
+
 class BookmarkModel;
 class BookmarkNode;
 class Profile;
 
 namespace test {
 
+class TestBookmarkClient : public BookmarkClient {

[tfarina, 2014/04/22 21:19:58]

Also, no. Leave this file for helper utility test functions. Please, move this
into test_bookmark_client.h

[sdefresne, 2014/04/23 16:10:18]

Done.

+ public:
+  // Create a BookmarkClient using the this object as its client.
+  BookmarkModel* CreateModel();
+
+  virtual base::CancelableTaskTracker::TaskId GetFaviconImageForURL(

[tfarina, 2014/04/22 21:19:58]

Group the overrides, can you also override everything in the private section?
And add a comment like: // BookmarkClient:

[sdefresne, 2014/04/23 16:10:18]

Done.

+      const GURL& page_url,
+      int icon_types,
+      int desired_size_in_dip,
+      const FaviconImageCallback& callback,
+      base::CancelableTaskTracker* tracker) OVERRIDE;
+
+  virtual bool SupportsTypedCountForNodes() OVERRIDE;
+
+  virtual void GetTypedCountForNodes(
+      const NodeSet& nodes,
+      NodeTypedCountPairs* node_typed_count_pairs) OVERRIDE;
+
+  virtual void RecordAction(const base::UserMetricsAction& action) OVERRIDE;
+
+ private:
+  virtual void OnLoad() OVERRIDE;
+
+  virtual void OnClearStore() OVERRIDE;
+
+  virtual void NotifyHistoryAboutRemovedBookmarks(
+      const std::set<GURL>& removed_bookmark_urls) OVERRIDE;
+};

[tfarina, 2014/04/22 21:19:58]

DISALLOW_COPY_AND_ASSIGN

[sdefresne, 2014/04/23 16:10:18]

Done.

+
 // Blocks until |model| finishes loading.
 void WaitForBookmarkModelToLoad(BookmarkModel* model);
 void WaitForBookmarkModelToLoad(Profile* profile);