chrome/browser/bookmarks/bookmark_utils.cc - Issue 242693003: Introduce BookmarkClient interface to abstract embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_test_helpers.cc ('K') | « chrome/browser/bookmarks/bookmark_test_helpers.cc ('k') | chrome/browser/bookmarks/bookmark_utils_unittest.cc » ('j') | chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/bookmark_utils.cc

diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc

index c41a933e8c23f17c0b18e56319b44343b92a473a..b27ebdee76afe0f856b8f8d01216bdfbc8d7521a 100644

--- a/chrome/browser/bookmarks/bookmark_utils.cc

+++ b/chrome/browser/bookmarks/bookmark_utils.cc

@@ -10,6 +10,7 @@

#include "base/files/file_path.h"

#include "base/i18n/case_conversion.h"

#include "base/i18n/string_search.h"

+#include "base/metrics/user_metrics_action.h"

#include "base/prefs/pref_service.h"

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

@@ -18,7 +19,6 @@

#include "components/bookmarks/core/common/bookmark_pref_names.h"

#include "components/query_parser/query_parser.h"

#include "components/user_prefs/pref_registry_syncable.h"

-#include "content/public/browser/user_metrics.h"

#include "net/base/net_util.h"

#include "ui/base/models/tree_node_iterator.h"

@@ -368,7 +368,7 @@ void AddIfNotBookmarked(BookmarkModel* model,

if (!bookmarks.empty())

return; // Nothing to do, a bookmark with that url already exists.

- content::RecordAction(base::UserMetricsAction("BookmarkAdded"));

+ model->client()->RecordAction(base::UserMetricsAction("BookmarkAdded"));

const BookmarkNode* parent = model->GetParentForNewNodes();

model->AddURL(parent, parent->child_count(), title, url);

}