Introduce BookmarkClient interface to abstract embedder

chrome/browser/bookmarks/bookmark_test_helpers.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_test_helpers.h"
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
@@ skipping 79 matching lines @@
       break;
     }
   }
   return end_pos;
 }
 
 }  // namespace
 
 namespace test {
 
+BookmarkModel* TestBookmarkClient::CreateModel() {
+  scoped_ptr<BookmarkModel> bookmark_model(new BookmarkModel(this));

[tfarina, 2014/04/22 21:19:58]

I don't think using scoped_ptr + release here helps much. I would simply
allocate on the heap and return the raw pointer. Also make sure to document the
ownership in the declaration of CreateModel, saying to clients that
TestBookmarkClient does not own the pointer and the caller is responsible for
releasing the memory after it is done with it.

[sdefresne, 2014/04/23 16:10:18]

Done.

+  bookmark_model->DoneLoading(bookmark_model->CreateLoadDetails());
+  return bookmark_model.release();
+}
+
+base::CancelableTaskTracker::TaskId TestBookmarkClient::GetFaviconImageForURL(
+    const GURL& page_url,
+    int icon_types,
+    int desired_size_in_dip,
+    const FaviconImageCallback& callback,
+    base::CancelableTaskTracker* tracker) {
+  return base::CancelableTaskTracker::kBadTaskId;
+}
+
+bool TestBookmarkClient::SupportsTypedCountForNodes() {
+  return false;
+}
+
+void TestBookmarkClient::GetTypedCountForNodes(
+    const NodeSet& nodes,
+    NodeTypedCountPairs* node_typed_count_pairs) {
+  NOTREACHED();
+}
+
+void TestBookmarkClient::RecordAction(const base::UserMetricsAction& action) {
+}
+
+void TestBookmarkClient::OnLoad() {
+}
+
+void TestBookmarkClient::OnClearStore() {
+}
+
+void TestBookmarkClient::NotifyHistoryAboutRemovedBookmarks(
+    const std::set<GURL>& removed_bookmark_urls) {
+}
+
 void WaitForBookmarkModelToLoad(BookmarkModel* model) {
   if (model->loaded())
     return;
   base::RunLoop run_loop;
   BookmarkLoadObserver observer(content::GetQuitTaskForRunLoop(&run_loop));
   model->AddObserver(&observer);
   content::RunThisRunLoop(&run_loop);
   model->RemoveObserver(&observer);
   DCHECK(model->loaded());
 }
@@ skipping 23 matching lines @@
                              const BookmarkNode* node,
                              const std::string& model_string) {
   DCHECK(node);
   std::string::size_type start_pos = 0;
   std::string::size_type end_pos =
       AddNodesFromString(model, node, model_string, start_pos);
   DCHECK(end_pos == std::string::npos);
 }
 
 }  // namespace test