Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2426223002: Reduce FOR_EACH_OBSERVER macro usage in chrome/browser (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, qsr+mojo_chromium.org, media-router+watch_chromium.org, Lei Zhang, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, Aaron Boodman, mcasas+watch+vc_chromium.org, mac-reviews_chromium.org, darin (slow to review), tommycli, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce FOR_EACH_OBSERVER macro usage in chrome/browser Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504 Cr-Commit-Position: refs/heads/master@{#426105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -76 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/background/background_contents.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/command_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/media/router/issue_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 6 chunks +17 lines, -22 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Eric Willigers
4 years, 2 months ago (2016-10-18 23:36:01 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-18 23:42:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426223002/1
4 years, 2 months ago (2016-10-18 23:48:07 UTC) #8
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-10-19 01:41:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426223002/1
4 years, 2 months ago (2016-10-19 02:03:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426223002/1
4 years, 2 months ago (2016-10-19 03:20:10 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/284370)
4 years, 2 months ago (2016-10-19 04:11:36 UTC) #17
Eric Willigers
4 years, 2 months ago (2016-10-19 04:38:34 UTC) #18
This landed as
commit d9d3ea15202868716617ceb73ee8d5595778d504
Date:   Tue Oct 18 17:31:10 2016 -0700
Review-Url: https://codereview.chromium.org/2426223002
Cr-Commit-Position: refs/heads/master@{#426105}

Powered by Google App Engine
This is Rietveld 408576698