Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/background/background_contents.cc

Issue 2426223002: Reduce FOR_EACH_OBSERVER macro usage in chrome/browser (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/background/background_application_list_model.cc ('k') | chrome/browser/command_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_contents.cc
diff --git a/chrome/browser/background/background_contents.cc b/chrome/browser/background/background_contents.cc
index 7192ee7ad7f43289fa075cd698db259a6db373e6..3d3d824d4e60db2359f411736bd488b21e1cdc57 100644
--- a/chrome/browser/background/background_contents.cc
+++ b/chrome/browser/background/background_contents.cc
@@ -99,9 +99,8 @@ BackgroundContents::~BackgroundContents() {
chrome::NOTIFICATION_BACKGROUND_CONTENTS_DELETED,
content::Source<Profile>(profile_),
content::Details<BackgroundContents>(this));
- FOR_EACH_OBSERVER(extensions::DeferredStartRenderHostObserver,
- deferred_start_render_host_observer_list_,
- OnDeferredStartRenderHostDestroyed(this));
+ for (auto& observer : deferred_start_render_host_observer_list_)
+ observer.OnDeferredStartRenderHostDestroyed(this);
extension_host_delegate_->GetExtensionHostQueue()->Remove(this);
}
@@ -174,17 +173,15 @@ void BackgroundContents::RenderProcessGone(base::TerminationStatus status) {
void BackgroundContents::DidStartLoading() {
// BackgroundContents only loads once, so this can only be the first time it
// has started loading.
- FOR_EACH_OBSERVER(extensions::DeferredStartRenderHostObserver,
- deferred_start_render_host_observer_list_,
- OnDeferredStartRenderHostDidStartFirstLoad(this));
+ for (auto& observer : deferred_start_render_host_observer_list_)
+ observer.OnDeferredStartRenderHostDidStartFirstLoad(this);
}
void BackgroundContents::DidStopLoading() {
// BackgroundContents only loads once, so this can only be the first time
// it has stopped loading.
- FOR_EACH_OBSERVER(extensions::DeferredStartRenderHostObserver,
- deferred_start_render_host_observer_list_,
- OnDeferredStartRenderHostDidStopFirstLoad(this));
+ for (auto& observer : deferred_start_render_host_observer_list_)
+ observer.OnDeferredStartRenderHostDidStopFirstLoad(this);
}
void BackgroundContents::Observe(int type,
« no previous file with comments | « chrome/browser/background/background_application_list_model.cc ('k') | chrome/browser/command_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698