Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6152)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl.cc

Issue 2426223002: Reduce FOR_EACH_OBSERVER macro usage in chrome/browser (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_mojo_impl.cc
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
index 0155befb565755e77520c24b47b319a01e1e4747..9517982d9310c78ec0ee681a5bb654793d672d2b 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
@@ -201,9 +201,10 @@ void MediaRouterMojoImpl::OnSinksReceived(
DVLOG_WITH_INSTANCE(1)
<< "Received sink list without any active observers: " << media_source;
} else {
- FOR_EACH_OBSERVER(
- MediaSinksObserver, sinks_query->observers,
- OnSinksUpdated(sinks_query->cached_sink_list, sinks_query->origins));
+ for (auto& observer : sinks_query->observers) {
+ observer.OnSinksUpdated(sinks_query->cached_sink_list,
+ sinks_query->origins);
+ }
}
}
@@ -227,9 +228,8 @@ void MediaRouterMojoImpl::OnRoutesUpdated(
for (size_t i = 0; i < routes.size(); ++i)
routes_converted.push_back(routes[i].To<MediaRoute>());
- FOR_EACH_OBSERVER(
- MediaRoutesObserver, it->second->observers,
- OnRoutesUpdated(routes_converted, joinable_route_ids));
+ for (auto& observer : it->second->observers)
+ observer.OnRoutesUpdated(routes_converted, joinable_route_ids);
}
void MediaRouterMojoImpl::RouteResponseReceived(
@@ -710,8 +710,8 @@ void MediaRouterMojoImpl::OnRouteMessagesReceived(
return;
}
- FOR_EACH_OBSERVER(RouteMessageObserver, *observer_list,
- OnMessagesReceived(messages));
+ for (auto& observer : *observer_list)
+ observer.OnMessagesReceived(messages);
}
void MediaRouterMojoImpl::OnSinkAvailabilityUpdated(
« no previous file with comments | « chrome/browser/media/router/issue_manager.cc ('k') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698