Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content (Closed)

Created:
4 years, 2 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary URL parsing for GURL comparisons in //content This patch uses the new operator==(const GURL&, const StringPiece&) function to optimize URL comparisons with string constants, in //content. BUG=655467 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a3bd0b372da5a2dffefbf1d928db1695ae2a9939 Cr-Commit-Position: refs/heads/master@{#426250}

Patch Set 1 #

Patch Set 2 : rebase on dependent PS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M content/browser/frame_host/debug_urls.cc View 4 chunks +15 lines, -16 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/navigation_params.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
Charlie Harrison
jochen@, PTAL. Note that the dependent CL has your l-g-t-m but has changed since you ...
4 years, 2 months ago (2016-10-18 15:11:25 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-19 14:26:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424913003/20001
4 years, 2 months ago (2016-10-19 16:34:50 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 18:41:15 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:10:24 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3bd0b372da5a2dffefbf1d928db1695ae2a9939
Cr-Commit-Position: refs/heads/master@{#426250}

Powered by Google App Engine
This is Rietveld 408576698