content/browser/frame_host/frame_tree_node.cc - Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content (Closed)

Patch Set: rebase on dependent PS Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/frame_tree_node.cc

diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc

index 3f789ef905cca6578e1778ef5eea8944e8e3c3e8..9fcb48b80b71b36f76b718ecfada7dbba0f37746 100644

--- a/content/browser/frame_host/frame_tree_node.cc

+++ b/content/browser/frame_host/frame_tree_node.cc

@@ -206,7 +206,7 @@ void FrameTreeNode::SetOpener(FrameTreeNode* opener) {

}

void FrameTreeNode::SetCurrentURL(const GURL& url) {

- if (!has_committed_real_load_ && url != GURL(url::kAboutBlankURL))

+ if (!has_committed_real_load_ && url != url::kAboutBlankURL)

has_committed_real_load_ = true;

current_frame_host()->set_last_committed_url(url);

blame_context_.TakeSnapshot();