content/browser/frame_host/frame_tree.cc - Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content (Closed)

Patch Set: rebase on dependent PS Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/frame_tree.cc

diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc

index 511454f4d1069275dedc0d193778593d0d395985..370946e428b8d77be1edc2b815a36d53b1b0ce29 100644

--- a/content/browser/frame_host/frame_tree.cc

+++ b/content/browser/frame_host/frame_tree.cc

@@ -418,7 +418,7 @@ void FrameTree::UpdateLoadProgress() {

// Ignore the current frame if it has not started loading,

// if the frame is cross-origin, or about:blank.

if (!node->has_started_loading() || !node->HasSameOrigin(*root_) ||

- node->current_url() == GURL(url::kAboutBlankURL))

+ node->current_url() == url::kAboutBlankURL)

continue;

progress += node->loading_progress();

frame_count++;