content/browser/frame_host/navigation_controller_impl.cc - Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2424913003: Avoid unnecessary URL parsing for GURL comparisons in //content (Closed)

Patch Set: rebase on dependent PS Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 5f011948a048814ba1a3fba4d83bf4f00aa74755..fa22b39f23f2949e88eded7db55ad372664dd86c 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -1463,7 +1463,7 @@ bool NavigationControllerImpl::IsURLInPageNavigation(

// We don't have sufficient information to identify

// that case at the moment, so always allow about:blank

// for now.

- last_committed_url == GURL(url::kAboutBlankURL) ||

+ last_committed_url == url::kAboutBlankURL ||

last_committed_url.GetOrigin() == url.GetOrigin() ||

committed_origin == origin ||

!prefs.web_security_enabled ||