Add unittest to avoid duplicate id in gpu driver bug list

Add unittest to avoid duplicate id in gpu driver bug list

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6e5a0fecef89dc8b1b2b723cec50bf1b8066c635
Cr-Commit-Position: refs/heads/master@{#425904}

[qiankun, 2016-10-17 07:15:54]

Description was changed from

==========
Add unittest to avoid duplicate id in gpu driver bug list

BUG=429053
==========

to

==========
Add unittest to avoid duplicate id in gpu driver bug list

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2016-10-17 10:29:13]

qiankun.miao@intel.com changed reviewers:
+ kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2016-10-17 10:29:13]

PTAL. This is to fix a request from
https://codereview.chromium.org/2413683002/#msg7.

[Zhenyao Mo, 2016-10-17 17:30:04]

Looks good.  Can you also add the same unittest to gpu_blacklist_unittest.cc

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_control_list.h
File gpu/config/gpu_control_list.h (right):

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_control_list...
gpu/config/gpu_control_list.h:95: bool has_duplicate_entry_id() const;
nit: duplicate -> duplicated

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_driver_bug_l...
File gpu/config/gpu_driver_bug_list_unittest.cc (right):

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_unittest.cc:210: TEST_F(GpuDriverBugListTest,
DuplicateBugIDCheck) {
nit: Duplicate -> Duplicated.

[qiankun, 2016-10-18 01:52:56]

Added unittest for GpuBlacklist, PTAL. Thanks!

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_control_list.h
File gpu/config/gpu_control_list.h (right):

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_control_list...
gpu/config/gpu_control_list.h:95: bool has_duplicate_entry_id() const;
On 2016/10/17 17:30:04, Zhenyao Mo wrote:
> nit: duplicate -> duplicated

Done.

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_driver_bug_l...
File gpu/config/gpu_driver_bug_list_unittest.cc (right):

https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_unittest.cc:210: TEST_F(GpuDriverBugListTest,
DuplicateBugIDCheck) {
On 2016/10/17 17:30:04, Zhenyao Mo wrote:
> nit: Duplicate -> Duplicated.

Done.

[Zhenyao Mo, 2016-10-18 02:22:17]

On 2016/10/18 01:52:56, qiankun wrote:
> Added unittest for GpuBlacklist, PTAL. Thanks!
> 
>
https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_control_list.h
> File gpu/config/gpu_control_list.h (right):
> 
>
https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_control_list...
> gpu/config/gpu_control_list.h:95: bool has_duplicate_entry_id() const;
> On 2016/10/17 17:30:04, Zhenyao Mo wrote:
> > nit: duplicate -> duplicated
> 
> Done.
> 
>
https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_driver_bug_l...
> File gpu/config/gpu_driver_bug_list_unittest.cc (right):
> 
>
https://codereview.chromium.org/2424733002/diff/1/gpu/config/gpu_driver_bug_l...
> gpu/config/gpu_driver_bug_list_unittest.cc:210: TEST_F(GpuDriverBugListTest,
> DuplicateBugIDCheck) {
> On 2016/10/17 17:30:04, Zhenyao Mo wrote:
> > nit: Duplicate -> Duplicated.
> 
> Done.

lgtm

[qiankun, 2016-10-18 03:26:52]

The CQ bit was checked by qiankun.miao@intel.com

[commit-bot: I haz the power, 2016-10-18 03:27:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 06:05:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-18 06:08:31]

Description was changed from

==========
Add unittest to avoid duplicate id in gpu driver bug list

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add unittest to avoid duplicate id in gpu driver bug list

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6e5a0fecef89dc8b1b2b723cec50bf1b8066c635
Cr-Commit-Position: refs/heads/master@{#425904}
==========

[commit-bot: I haz the power, 2016-10-18 06:08:32]

Patchset 2 (id:??) landed as
https://crrev.com/6e5a0fecef89dc8b1b2b723cec50bf1b8066c635
Cr-Commit-Position: refs/heads/master@{#425904}