Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: gpu/config/gpu_blacklist_unittest.cc

Issue 2424733002: Add unittest to avoid duplicate id in gpu driver bug list (Closed)
Patch Set: add unittest for GpuBlacklist Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/config/gpu_control_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_blacklist_unittest.cc
diff --git a/gpu/config/gpu_blacklist_unittest.cc b/gpu/config/gpu_blacklist_unittest.cc
index 8144b767faf8490db7026776fc08f08e01bc2c2e..420a4fbc4fafa91ec70df0bce8b58923d5e0a262 100644
--- a/gpu/config/gpu_blacklist_unittest.cc
+++ b/gpu/config/gpu_blacklist_unittest.cc
@@ -81,6 +81,13 @@ TEST_F(GpuBlacklistTest, CurrentBlacklistValidation) {
kSoftwareRenderingListJson, GpuBlacklist::kAllOs));
}
+TEST_F(GpuBlacklistTest, DuplicatedIDValidation) {
+ std::unique_ptr<GpuBlacklist> blacklist(GpuBlacklist::Create());
+ EXPECT_TRUE(blacklist->LoadList(
+ kSoftwareRenderingListJson, GpuBlacklist::kAllOs));
+ EXPECT_FALSE(blacklist->has_duplicated_entry_id());
+}
+
#define GPU_BLACKLIST_FEATURE_TEST(test_name, feature_name, feature_type) \
TEST_F(GpuBlacklistTest, test_name) { \
RunFeatureTest(feature_name, feature_type); \
« no previous file with comments | « no previous file | gpu/config/gpu_control_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698