Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: gpu/config/gpu_control_list.h

Issue 2424733002: Add unittest to avoid duplicate id in gpu driver bug list (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_CONFIG_GPU_CONTROL_LIST_H_ 5 #ifndef GPU_CONFIG_GPU_CONTROL_LIST_H_
6 #define GPU_CONFIG_GPU_CONTROL_LIST_H_ 6 #define GPU_CONFIG_GPU_CONTROL_LIST_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 std::string version() const; 84 std::string version() const;
85 85
86 // Check if we need more gpu info to make the decisions. 86 // Check if we need more gpu info to make the decisions.
87 // This is computed from the last MakeDecision() call. 87 // This is computed from the last MakeDecision() call.
88 // If yes, we should create a gl context and do a full gpu info collection. 88 // If yes, we should create a gl context and do a full gpu info collection.
89 bool needs_more_info() const { return needs_more_info_; } 89 bool needs_more_info() const { return needs_more_info_; }
90 90
91 // Returns the number of entries. This is only for tests. 91 // Returns the number of entries. This is only for tests.
92 size_t num_entries() const; 92 size_t num_entries() const;
93 93
94 // This is only for tests.
95 bool has_duplicate_entry_id() const;
Zhenyao Mo 2016/10/17 17:30:04 nit: duplicate -> duplicated
qiankun 2016/10/18 01:52:56 Done.
96
94 // Register a feature to FeatureMap - used to construct a GpuControlList. 97 // Register a feature to FeatureMap - used to construct a GpuControlList.
95 void AddSupportedFeature(const std::string& feature_name, int feature_id); 98 void AddSupportedFeature(const std::string& feature_name, int feature_id);
96 // Register whether "all" is recognized as all features. 99 // Register whether "all" is recognized as all features.
97 void set_supports_feature_type_all(bool supported); 100 void set_supports_feature_type_all(bool supported);
98 101
99 // Enables logging of control list decisions. 102 // Enables logging of control list decisions.
100 void enable_control_list_logging( 103 void enable_control_list_logging(
101 const std::string& control_list_logging_name) { 104 const std::string& control_list_logging_name) {
102 control_list_logging_enabled_ = true; 105 control_list_logging_enabled_ = true;
103 control_list_logging_name_ = control_list_logging_name; 106 control_list_logging_name_ = control_list_logging_name;
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 bool supports_feature_type_all_; 496 bool supports_feature_type_all_;
494 497
495 bool control_list_logging_enabled_; 498 bool control_list_logging_enabled_;
496 std::string control_list_logging_name_; 499 std::string control_list_logging_name_;
497 }; 500 };
498 501
499 } // namespace gpu 502 } // namespace gpu
500 503
501 #endif // GPU_CONFIG_GPU_CONTROL_LIST_H_ 504 #endif // GPU_CONFIG_GPU_CONTROL_LIST_H_
502 505
OLDNEW
« no previous file with comments | « no previous file | gpu/config/gpu_control_list.cc » ('j') | gpu/config/gpu_driver_bug_list_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698