Remove usage of FOR_EACH_OBSERVER macro in components/sync

Remove usage of FOR_EACH_OBSERVER macro in components/sync

Observer lists now support range-based for loops.

BUG=655021
Committed: https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a
Cr-Commit-Position: refs/heads/master@{#425864}

[Eric Willigers, 2016-10-16 23:04:49]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-16 23:04:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 23:44:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-16 23:44:14]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-10-17 01:17:37]

ericwilligers@chromium.org changed reviewers:
+ maxbogue@chromium.org

[maxbogue, 2016-10-17 16:54:58]

lgtm, though I'd prefer braces everywhere.

https://codereview.chromium.org/2424673002/diff/20001/components/sync/test/fa...
File components/sync/test/fake_server/fake_server.cc (right):

https://codereview.chromium.org/2424673002/diff/20001/components/sync/test/fa...
components/sync/test/fake_server/fake_server.cc:514: return true;
This sort of thing gives me anxiety, and is why I'd prefer for loops and if
statements to always have their {}'s, but apparently I'm in a minority with that
sentiment.

[Eric Willigers, 2016-10-17 23:31:24]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-10-17 23:31:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2424673002/#ps40001
(title: "blank line before return")

[commit-bot: I haz the power, 2016-10-17 23:32:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 02:37:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-18 02:41:17]

Description was changed from

==========
Remove usage of FOR_EACH_OBSERVER macro in components/sync

Observer lists now support range-based for loops.


BUG=655021
==========

to

==========
Remove usage of FOR_EACH_OBSERVER macro in components/sync

Observer lists now support range-based for loops.

BUG=655021

Committed: https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a
Cr-Commit-Position: refs/heads/master@{#425864}
==========

[commit-bot: I haz the power, 2016-10-18 02:41:18]

Patchset 3 (id:??) landed as
https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a
Cr-Commit-Position: refs/heads/master@{#425864}