Remove usage of FOR_EACH_OBSERVER macro in components/sync

components/sync/test/fake_server/fake_server.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/test/fake_server/fake_server.h"
 
 #include <algorithm>
 #include <limits>
 #include <set>
 #include <utility>
@@ skipping 491 matching lines @@
     // Record the ID if it was renamed.
     if (entity_id != client_entity.id_string()) {
       client_to_server_ids[client_entity.id_string()] = entity_id;
     }
 
     EntityMap::const_iterator iter = entities_.find(entity_id);
     CHECK(iter != entities_.end());
     committed_model_types.Put(iter->second->model_type());
   }
 
-  FOR_EACH_OBSERVER(Observer, observers_,
-                    OnCommit(invalidator_client_id, committed_model_types));
+  for (auto& observer : observers_)
+    observer.OnCommit(invalidator_client_id, committed_model_types);
   return true;

[maxbogue, 2016/10/17 16:54:58]

This sort of thing gives me anxiety, and is why I'd prefer for loops and if
statements to always have their {}'s, but apparently I'm in a minority with that
sentiment.

 }
 
 std::unique_ptr<base::DictionaryValue>
 FakeServer::GetEntitiesAsDictionaryValue() {
   DCHECK(thread_checker_.CalledOnValidThread());
   std::unique_ptr<base::DictionaryValue> dictionary(
       new base::DictionaryValue());
 
   // Initialize an empty ListValue for all ModelTypes.
   ModelTypeSet all_types = ModelTypeSet::All();
@@ skipping 194 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
   return weak_ptr_factory_.GetWeakPtr();
 }
 
 std::string FakeServer::GetStoreBirthday() const {
   DCHECK(thread_checker_.CalledOnValidThread());
   return base::Int64ToString(store_birthday_);
 }
 
 }  // namespace fake_server