components/sync/js/sync_js_controller.cc - Issue 2424673002: Remove usage of FOR_EACH_OBSERVER macro in components/sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/js/sync_js_controller.cc

Issue 2424673002: Remove usage of FOR_EACH_OBSERVER macro in components/sync (Closed)

Patch Set: blank line before return Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/js/sync_js_controller.cc

diff --git a/components/sync/js/sync_js_controller.cc b/components/sync/js/sync_js_controller.cc

index 087d20eaa311fa450262671c63acbace2260ed3f..1d598f63ff9d94614f9645e936ba619ad3b3f4d3 100644

--- a/components/sync/js/sync_js_controller.cc

+++ b/components/sync/js/sync_js_controller.cc

@@ -34,8 +34,8 @@ void SyncJsController::AttachJsBackend(

void SyncJsController::HandleJsEvent(const std::string& name,

const JsEventDetails& details) {

- FOR_EACH_OBSERVER(JsEventHandler, js_event_handlers_,

- HandleJsEvent(name, details));

+ for (auto& observer : js_event_handlers_)

+ observer.HandleJsEvent(name, details);

}

void SyncJsController::UpdateBackendEventHandler() {