components/sync/engine_impl/net/server_connection_manager.cc - Issue 2424673002: Remove usage of FOR_EACH_OBSERVER macro in components/sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/net/server_connection_manager.cc

Issue 2424673002: Remove usage of FOR_EACH_OBSERVER macro in components/sync (Closed)

Patch Set: blank line before return Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/net/server_connection_manager.cc

diff --git a/components/sync/engine_impl/net/server_connection_manager.cc b/components/sync/engine_impl/net/server_connection_manager.cc

index 21da65bc3b79e73b9062254b3015e5e59f1d065e..d2af65d634ab141195ec852ea4f976ff2dc486be 100644

--- a/components/sync/engine_impl/net/server_connection_manager.cc

+++ b/components/sync/engine_impl/net/server_connection_manager.cc

@@ -240,9 +240,8 @@ void ServerConnectionManager::SetServerStatus(

void ServerConnectionManager::NotifyStatusChanged() {

DCHECK(thread_checker_.CalledOnValidThread());

- FOR_EACH_OBSERVER(

- ServerConnectionEventListener, listeners_,

- OnServerConnectionEvent(ServerConnectionEvent(server_status_)));

+ for (auto& observer : listeners_)

+ observer.OnServerConnectionEvent(ServerConnectionEvent(server_status_));

}

bool ServerConnectionManager::PostBufferWithCachedAuth(