Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2422943002: Remove usage of FOR_EACH_OBSERVER macro in components/signin (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in components/signin Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8 Cr-Commit-Position: refs/heads/master@{#425737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M components/signin/core/browser/about_signin_internals.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M components/signin/core/browser/account_tracker_service.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/signin/core/browser/fake_signin_manager.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M components/signin/core/browser/gaia_cookie_manager_service.cc View 5 chunks +17 lines, -15 lines 0 comments Download
M components/signin/core/browser/signin_error_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/signin/core/browser/signin_manager.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M components/signin/core/browser/signin_manager_base.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-17 00:56:46 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm
4 years, 2 months ago (2016-10-17 17:02:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422943002/1
4 years, 2 months ago (2016-10-17 18:45:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 18:57:41 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 18:59:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8
Cr-Commit-Position: refs/heads/master@{#425737}

Powered by Google App Engine
This is Rietveld 408576698