Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: components/signin/core/browser/signin_manager.cc

Issue 2422943002: Remove usage of FOR_EACH_OBSERVER macro in components/signin (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_manager.cc
diff --git a/components/signin/core/browser/signin_manager.cc b/components/signin/core/browser/signin_manager.cc
index cb537ec9e6d27a02d1ff34596b1b1012884ed1b3..3880fc1f6fb4b0efd40713527a77ab2563af189d 100644
--- a/components/signin/core/browser/signin_manager.cc
+++ b/components/signin/core/browser/signin_manager.cc
@@ -141,9 +141,8 @@ void SigninManager::ClearTransientSigninData() {
void SigninManager::HandleAuthError(const GoogleServiceAuthError& error) {
ClearTransientSigninData();
- FOR_EACH_OBSERVER(SigninManagerBase::Observer,
- observer_list_,
- GoogleSigninFailed(error));
+ for (auto& observer : observer_list_)
+ observer.GoogleSigninFailed(error);
}
void SigninManager::SignOut(
@@ -201,9 +200,8 @@ void SigninManager::SignOut(
<< "IsSigninAllowed: " << IsSigninAllowed();
token_service_->RevokeAllCredentials();
- FOR_EACH_OBSERVER(SigninManagerBase::Observer,
- observer_list_,
- GoogleSignedOut(account_id, username));
+ for (auto& observer : observer_list_)
+ observer.GoogleSignedOut(account_id, username);
}
void SigninManager::Initialize(PrefService* local_state) {
@@ -375,10 +373,11 @@ void SigninManager::OnSignedIn() {
possibly_invalid_email_.clear();
signin_manager_signed_in_ = true;
- FOR_EACH_OBSERVER(
- SigninManagerBase::Observer, observer_list_,
- GoogleSigninSucceeded(GetAuthenticatedAccountId(),
- GetAuthenticatedAccountInfo().email, password_));
+ for (auto& observer : observer_list_) {
+ observer.GoogleSigninSucceeded(GetAuthenticatedAccountId(),
+ GetAuthenticatedAccountInfo().email,
+ password_);
+ }
client_->OnSignedIn(GetAuthenticatedAccountId(), gaia_id,
GetAuthenticatedAccountInfo().email, password_);
« no previous file with comments | « components/signin/core/browser/signin_error_controller.cc ('k') | components/signin/core/browser/signin_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698