Remove usage of FOR_EACH_OBSERVER macro in components/signin

components/signin/core/browser/signin_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/signin_manager.h"
 
 #include <string>
 #include <vector>
 
 #include "base/metrics/histogram_macros.h"
@@ skipping 123 matching lines @@
   possibly_invalid_gaia_id_.clear();
   possibly_invalid_email_.clear();
   password_.clear();
   type_ = SIGNIN_TYPE_NONE;
   temp_refresh_token_.clear();
 }
 
 void SigninManager::HandleAuthError(const GoogleServiceAuthError& error) {
   ClearTransientSigninData();
 
-  FOR_EACH_OBSERVER(SigninManagerBase::Observer,
-                    observer_list_,
-                    GoogleSigninFailed(error));
+  for (auto& observer : observer_list_)
+    observer.GoogleSigninFailed(error);
 }
 
 void SigninManager::SignOut(
     signin_metrics::ProfileSignout signout_source_metric,
     signin_metrics::SignoutDelete signout_delete_metric) {
   DCHECK(IsInitialized());
 
   signin_metrics::LogSignout(signout_source_metric, signout_delete_metric);
   if (!IsAuthenticated()) {
     if (AuthInProgress()) {
@@ skipping 37 matching lines @@
                          signed_in_duration.InMinutes());
   }
 
   // Revoke all tokens before sending signed_out notification, because there
   // may be components that don't listen for token service events when the
   // profile is not connected to an account.
   LOG(WARNING) << "Revoking refresh token on server. Reason: sign out, "
                << "IsSigninAllowed: " << IsSigninAllowed();
   token_service_->RevokeAllCredentials();
 
-  FOR_EACH_OBSERVER(SigninManagerBase::Observer,
-                    observer_list_,
-                    GoogleSignedOut(account_id, username));
+  for (auto& observer : observer_list_)
+    observer.GoogleSignedOut(account_id, username);
 }
 
 void SigninManager::Initialize(PrefService* local_state) {
   SigninManagerBase::Initialize(local_state);
 
   // local_state can be null during unit tests.
   if (local_state) {
     local_state_pref_registrar_.Init(local_state);
     local_state_pref_registrar_.Add(
         prefs::kGoogleServicesUsernamePattern,
@@ skipping 151 matching lines @@
                                 base::Time::Now().ToInternalValue());
   SetAuthenticatedAccountInfo(possibly_invalid_gaia_id_,
                               possibly_invalid_email_);
   const std::string gaia_id = possibly_invalid_gaia_id_;
 
   possibly_invalid_account_id_.clear();
   possibly_invalid_gaia_id_.clear();
   possibly_invalid_email_.clear();
   signin_manager_signed_in_ = true;
 
-  FOR_EACH_OBSERVER(
-      SigninManagerBase::Observer, observer_list_,
-      GoogleSigninSucceeded(GetAuthenticatedAccountId(),
-                            GetAuthenticatedAccountInfo().email, password_));
+  for (auto& observer : observer_list_) {
+    observer.GoogleSigninSucceeded(GetAuthenticatedAccountId(),
+                                   GetAuthenticatedAccountInfo().email,
+                                   password_);
+  }
 
   client_->OnSignedIn(GetAuthenticatedAccountId(), gaia_id,
                       GetAuthenticatedAccountInfo().email, password_);
 
   signin_metrics::LogSigninProfile(client_->IsFirstRun(),
                                    client_->GetInstallDate());
 
   DisableOneClickSignIn(client_->GetPrefs());  // Don't ever offer again.
 
   PostSignedIn();
@@ skipping 24 matching lines @@
     account_tracker_service()->SetMigrationDone();
     token_service_->RemoveObserver(this);
   }
 }
 
 void SigninManager::ProhibitSignout(bool prohibit_signout) {
   prohibit_signout_ = prohibit_signout;
 }
 
 bool SigninManager::IsSignoutProhibited() const { return prohibit_signout_; }