components/signin/core/browser/signin_error_controller.cc - Issue 2422943002: Remove usage of FOR_EACH_OBSERVER macro in components/signin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_error_controller.cc

Issue 2422943002: Remove usage of FOR_EACH_OBSERVER macro in components/signin (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/signin_error_controller.cc

diff --git a/components/signin/core/browser/signin_error_controller.cc b/components/signin/core/browser/signin_error_controller.cc

index 1fa6e9f9112453b4fc0f73fa50392862f1642d5b..6dbaf23b1517ebe518dd4dad49e954e64fa76b6d 100644

--- a/components/signin/core/browser/signin_error_controller.cc

+++ b/components/signin/core/browser/signin_error_controller.cc

@@ -91,7 +91,8 @@ void SigninErrorController::AuthStatusChanged() {

if (error_changed) {

signin_metrics::LogAuthError(auth_error_.state());

- FOR_EACH_OBSERVER(Observer, observer_list_, OnErrorChanged());

+ for (auto& observer : observer_list_)

+ observer.OnErrorChanged();

}