Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2422923002: Reduce usage of FOR_EACH_OBSERVER macro in content/browser (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
ajwong+watch_chromium.org, asanka, blink-worker-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, horo+watch_chromium.org, jam, jbauman+watch_chromium.org, jsbell+serviceworker_chromium.org, kalyank, kinuko+watch, kinuko+serviceworker, michaeln, nasko+codewatch_chromium.org, nhiroki, pfeldman, piman+watch_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, sievers+watch_chromium.org, tracing+reviews_chromium.org, tzik, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of FOR_EACH_OBSERVER macro in content/browser Observer lists now support range-based for loops. BUG=655021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b Cr-Commit-Position: refs/heads/master@{#425648}

Patch Set 1 #

Patch Set 2 : skip cases in 2418143004 and 2418373002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -87 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M content/browser/appcache/appcache_group.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_host.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_service_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_manager.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/notification_service_impl.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/browser/site_instance_impl.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/webrtc/webrtc_internals.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Eric Willigers
4 years, 2 months ago (2016-10-16 23:34:09 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-17 09:54:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422923002/20001
4 years, 2 months ago (2016-10-17 10:26:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 10:32:57 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 10:35:29 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b
Cr-Commit-Position: refs/heads/master@{#425648}

Powered by Google App Engine
This is Rietveld 408576698