content/browser/appcache/appcache_group.cc - Issue 2422923002: Reduce usage of FOR_EACH_OBSERVER macro in content/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_group.cc

Issue 2422923002: Reduce usage of FOR_EACH_OBSERVER macro in content/browser (Closed)

Patch Set: skip cases in 2418143004 and 2418373002 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/appcache/appcache_group.cc

diff --git a/content/browser/appcache/appcache_group.cc b/content/browser/appcache/appcache_group.cc

index 0e8f3c496da0bf3ca4c84817a234cb23ef34b2ec..573983eba6e803f29f8c7b168d605e8c03453bba 100644

--- a/content/browser/appcache/appcache_group.cc

+++ b/content/browser/appcache/appcache_group.cc

@@ -260,7 +260,8 @@ void AppCacheGroup::SetUpdateAppCacheStatus(UpdateAppCacheStatus status) {

// deletion by adding an extra ref in this scope (but only if we're not

// in our destructor).

scoped_refptr<AppCacheGroup> protect(is_in_dtor_ ? NULL : this);

- FOR_EACH_OBSERVER(UpdateObserver, observers_, OnUpdateComplete(this));

+ for (auto& observer : observers_)

+ observer.OnUpdateComplete(this);

if (!queued_updates_.empty())

ScheduleUpdateRestart(kUpdateRestartDelayMs);

}