Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: content/browser/appcache/appcache_host.cc

Issue 2422923002: Reduce usage of FOR_EACH_OBSERVER macro in content/browser (Closed)
Patch Set: skip cases in 2418143004 and 2418373002 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_group.cc ('k') | content/browser/appcache/appcache_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_host.cc
diff --git a/content/browser/appcache/appcache_host.cc b/content/browser/appcache/appcache_host.cc
index 697b2bdf8d0432babc5b3fc057e7d9b22c49ac88..adcefe08f58db1828a62f8cf782ca04f340a1881 100644
--- a/content/browser/appcache/appcache_host.cc
+++ b/content/browser/appcache/appcache_host.cc
@@ -62,7 +62,8 @@ AppCacheHost::AppCacheHost(int host_id, AppCacheFrontend* frontend,
AppCacheHost::~AppCacheHost() {
service_->RemoveObserver(this);
- FOR_EACH_OBSERVER(Observer, observers_, OnDestructionImminent(this));
+ for (auto& observer : observers_)
+ observer.OnDestructionImminent(this);
if (associated_cache_.get())
associated_cache_->UnassociateHost(this);
if (group_being_updated_.get())
@@ -453,7 +454,8 @@ void AppCacheHost::FinishCacheSelection(
else if (!pending_swap_cache_callback_.is_null())
DoPendingSwapCache();
- FOR_EACH_OBSERVER(Observer, observers_, OnCacheSelectionComplete(this));
+ for (auto& observer : observers_)
+ observer.OnCacheSelectionComplete(this);
}
void AppCacheHost::OnServiceReinitialized(
« no previous file with comments | « content/browser/appcache/appcache_group.cc ('k') | content/browser/appcache/appcache_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698