Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: content/browser/site_instance_impl.cc

Issue 2422923002: Reduce usage of FOR_EACH_OBSERVER macro in content/browser (Closed)
Patch Set: skip cases in 2418143004 and 2418373002 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_instance_impl.cc
diff --git a/content/browser/site_instance_impl.cc b/content/browser/site_instance_impl.cc
index a55d786e8dbdf1cd40d30ba643cda5432aeb95f7..c12a0c79160a24dea7b2667816cb670fc4f89114 100644
--- a/content/browser/site_instance_impl.cc
+++ b/content/browser/site_instance_impl.cc
@@ -244,8 +244,10 @@ void SiteInstanceImpl::IncrementActiveFrameCount() {
}
void SiteInstanceImpl::DecrementActiveFrameCount() {
- if (--active_frame_count_ == 0)
- FOR_EACH_OBSERVER(Observer, observers_, ActiveFrameCountIsZero(this));
+ if (--active_frame_count_ == 0) {
+ for (auto& observer : observers_)
+ observer.ActiveFrameCountIsZero(this);
+ }
}
void SiteInstanceImpl::IncrementRelatedActiveContentsCount() {
@@ -395,13 +397,15 @@ void SiteInstanceImpl::RenderProcessHostDestroyed(RenderProcessHost* host) {
void SiteInstanceImpl::RenderProcessWillExit(RenderProcessHost* host) {
// TODO(nick): http://crbug.com/575400 - RenderProcessWillExit might not serve
// any purpose here.
- FOR_EACH_OBSERVER(Observer, observers_, RenderProcessGone(this));
+ for (auto& observer : observers_)
+ observer.RenderProcessGone(this);
}
void SiteInstanceImpl::RenderProcessExited(RenderProcessHost* host,
base::TerminationStatus status,
int exit_code) {
- FOR_EACH_OBSERVER(Observer, observers_, RenderProcessGone(this));
+ for (auto& observer : observers_)
+ observer.RenderProcessGone(this);
}
void SiteInstanceImpl::LockToOrigin() {
« no previous file with comments | « content/browser/shared_worker/shared_worker_service_impl.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698