static_cast check should allow static_cast inside to* methods

static_cast check should allow static_cast inside to* methods

The check was there, but range(N, N+1) yields [N] not [N, N+1] so this check
basically was a no-op
BUG=

[alecflett, 2013-09-20 18:53:29]

This fixes the static_cast issue when you have to use a static_cast inside a to*
definition.

[eseidel, 2013-09-20 18:55:40]

I believe we have the ability to test this, so we should.  This doesn't really
need to be your resposibility, since you went out of your way to fix up this,
but w/o a test this sort of thing can break again. :(

lgtm, but please consider adding a test (or proding the original author do so).

[commit-bot: I haz the power, 2013-09-20 18:57:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/24227005/1

[alecflett, 2013-09-20 18:58:54]

On 2013/09/20 18:55:40, eseidel wrote:
> I believe we have the ability to test this, so we should.  This doesn't really
> need to be your resposibility, since you went out of your way to fix up this,
> but w/o a test this sort of thing can break again. :(
> 
> lgtm, but please consider adding a test (or proding the original author do
so).

I'll prod.

[commit-bot: I haz the power, 2013-09-21 00:26:15]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-09-21 03:03:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/24227005/1

[commit-bot: I haz the power, 2013-09-21 03:03:35]

Failed to apply patch for Tools/Scripts/webkitpy/style/checkers/cpp.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/Scripts/webkitpy/style/checkers/cpp.py
  Hunk #1 FAILED at 3509.
  1 out of 1 hunk FAILED -- saving rejects to file
Tools/Scripts/webkitpy/style/checkers/cpp.py.rej

Patch:       Tools/Scripts/webkitpy/style/checkers/cpp.py
Index: Tools/Scripts/webkitpy/style/checkers/cpp.py
diff --git a/Tools/Scripts/webkitpy/style/checkers/cpp.py
b/Tools/Scripts/webkitpy/style/checkers/cpp.py
index
41c8450e5e06fb30f732ac73516d3889d516cc3e..8b84bdeb171f28e69b2e0ecc040d59165066cc2d
100644
--- a/Tools/Scripts/webkitpy/style/checkers/cpp.py
+++ b/Tools/Scripts/webkitpy/style/checkers/cpp.py
@@ -3509,7 +3509,7 @@ def check_for_object_static_cast(processing_file,
line_number, line, error):
     # Ensure found static_cast instance is not from within toFoo definition
itself.
     if (os.path.basename(processing_file) == header_file):
         for item in matches:
-            if line_number in range(item[1], item[2]):
+            if line_number in range(item[1], item[2] + 1):
                 report_error = False
                 break

[r.kasibhatla, 2013-09-23 03:12:07]

https://codereview.chromium.org/24227005/diff/1/Tools/Scripts/webkitpy/style/...
File Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/24227005/diff/1/Tools/Scripts/webkitpy/style/...
Tools/Scripts/webkitpy/style/checkers/cpp.py:3512: if line_number in
range(item[1], item[2] + 1):
I believe you are doing +1 here to enable the search of static_cast inside toFoo
function (from signature to end } itself). If so, then this is not needed here.
I am doing a +1 for the extra line number while adding the line numbers of toFoo
function into the "matches" map itself.
+1 again is not needed explicitly here.