static_cast check should allow static_cast inside to* methods

Tools/Scripts/webkitpy/style/checkers/cpp.py

 # -*- coding: utf-8 -*-
 #
 # Copyright (C) 2009, 2010, 2012 Google Inc. All rights reserved.
 # Copyright (C) 2009 Torch Mobile Inc.
 # Copyright (C) 2009 Apple Inc. All rights reserved.
 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
@@ skipping 3491 matching lines @@
     matches = check_for_toFoo_definition(header_file, ''.join(('to', class_name)), error)
     # Ignore (for now) if not able to find the header where toFoo might be defined.
     # TODO: Handle cases where Classname might be defined in some other header.
     if matches is None:
         return
 
     report_error = True
     # Ensure found static_cast instance is not from within toFoo definition itself.
     if (os.path.basename(processing_file) == header_file):
         for item in matches:
-            if line_number in range(item[1], item[2]):
+            if line_number in range(item[1], item[2] + 1):

[r.kasibhatla, 2013/09/23 03:12:07]

I believe you are doing +1 here to enable the search of static_cast inside toFoo
function (from signature to end } itself). If so, then this is not needed here.
I am doing a +1 for the extra line number while adding the line numbers of toFoo
function into the "matches" map itself.
+1 again is not needed explicitly here.

                 report_error = False
                 break
 
     if report_error:
         if len(matches):
             # toFoo is defined - enforce using it.
             # TODO: Suggest an appropriate toFoo from the alternatives present in matches.
             error(line_number, 'readability/check', 4,
                   'static_cast of class objects is not allowed. Use to%s defined in %s.' %
                   (class_name, header_file))
@@ skipping 497 matching lines @@
                        self.handle_style_error, self.min_confidence)
 
 
 # FIXME: Remove this function (requires refactoring unit tests).
 def process_file_data(filename, file_extension, lines, error, min_confidence, unit_test_config):
     global _unit_test_config
     _unit_test_config = unit_test_config
     checker = CppChecker(filename, file_extension, error, min_confidence)
     checker.check(lines)
     _unit_test_config = {}