Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2198)

Unified Diff: Tools/Scripts/webkitpy/style/checkers/cpp.py

Issue 24227005: static_cast check should allow static_cast inside to* methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/style/checkers/cpp.py
diff --git a/Tools/Scripts/webkitpy/style/checkers/cpp.py b/Tools/Scripts/webkitpy/style/checkers/cpp.py
index 41c8450e5e06fb30f732ac73516d3889d516cc3e..8b84bdeb171f28e69b2e0ecc040d59165066cc2d 100644
--- a/Tools/Scripts/webkitpy/style/checkers/cpp.py
+++ b/Tools/Scripts/webkitpy/style/checkers/cpp.py
@@ -3509,7 +3509,7 @@ def check_for_object_static_cast(processing_file, line_number, line, error):
# Ensure found static_cast instance is not from within toFoo definition itself.
if (os.path.basename(processing_file) == header_file):
for item in matches:
- if line_number in range(item[1], item[2]):
+ if line_number in range(item[1], item[2] + 1):
r.kasibhatla 2013/09/23 03:12:07 I believe you are doing +1 here to enable the sear
report_error = False
break
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698